openjdk
8273979: move some os time related functions to os_posix for POSIX platforms
Hi all,
This pull request contains a backport of commit 1c6fa113 from the openjdk/jdk repository.
The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt.
The backport applies cleanly, was created by the /backport command.
Thanks!
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8273979 needs maintainer approval
Warning
⚠️ Found leading lowercase letter in issue title for 8273979: move some os time related functions to os_posix for POSIX platforms
Issue
- JDK-8273979: move some os time related functions to os_posix for POSIX platforms (Enhancement - P4 - Requested)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2831/head:pull/2831
$ git checkout pull/2831
Update a local copy of the PR:
$ git checkout pull/2831
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2831/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2831
View PR using the GUI difftool:
$ git pr show -t 2831
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2831.diff
Webrev
:wave: Welcome back rvansa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
⚠️ @rvansa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
Hi @rvansa I am not so happy about this backport. Simplifying another project is not an eligible reason to backport things. Also, you did not test macos and expecially not aix. Does that still build?
Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality.
MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing.
Hi @rvansa @suchismith1993, Suchismith, could you verify that the backport is fine on aix? Thanks! @rvansa, you find people involved in the aix port on the corresponding project page https://wiki.openjdk.org/display/PPCAIXPort or on the OpenJDK census.
@rvansa I am currently facing some issue with my AIX development machine. Some migration in progress. By When are you expecting this to be tested?
@suchismith1993 No hurry, but it would be nice if you can try in a few weeks. Thank you!
Hi, I removed the approval label for now from the JBS issue. Label again if it is tested. Thanks.
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.