8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp

[rvansa]

Hi all,

This pull request contains a backport of commit 02f79008 from the openjdk/jdk repository.

The commit being backported was authored by Albert Mingkun Yang on 15 Nov 2021 and was reviewed by Thomas Schatzl and Stefan Johansson.

The backport is not clean; some method return types differ in later JDK versions.

Thanks!

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8276932 needs maintainer approval

Issue

• JDK-8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp (Enhancement - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2830/head:pull/2830
$ git checkout pull/2830

Update a local copy of the PR:
$ git checkout pull/2830
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2830/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2830

View PR using the GUI difftool:
$ git pr show -t 2830

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2830.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back rvansa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 00: Full (ff0f3b73)

[GoeLin]

There are GHA errors.

[openjdk[bot]]

⚠️ @rvansa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rvansa]

@GoeLin Thanks, one failure was failure to fetch JTReg (infra problem), I am re-running the failed ClhsdbSource test since I find it difficult to relate to changes in this PR.

[rvansa]

The checks are now green (no changes, just rerun).

[bridgekeeper[bot]]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[rvansa]

bump

[phohensee]

You need to ask for maintainer approval using "/approval request ".

[rvansa]

@phohensee Actually I've added the jdk17u-fix-request label in JIRA, but it was removed by @GoeLin - so is this practically a rejection?

[phohensee]

It's not a rejection (that would be jdk17u-fix-no), rather a request for more information, i.e., risk, testing, etc. But, in this case you've provided that, so I'd re-tag the issue and ask what extra info is needed.

[bridgekeeper[bot]]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.