8327474: Review use of java.io.tmpdir in jdk tests

[sendaoYan]

Hi all,

This pull request contains a backport of commit af6c5854 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers.

The backport not clean because jdk17u-dev doesn't have test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java, all other files are backported cleanly. Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.

Additional testing:

• [x] full jtreg tests on linux x64
• [x] full jtreg tests in linux aarch64

Thanks!

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] JDK-8327474 needs maintainer approval
• [x] Commit message must refer to an issue

Issue

• JDK-8327474: Review use of java.io.tmpdir in jdk tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2811/head:pull/2811
$ git checkout pull/2811

Update a local copy of the PR:
$ git checkout pull/2811
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2811

View PR using the GUI difftool:
$ git pr show -t 2811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2811.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327474: Review use of java.io.tmpdir in jdk tests

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 257 new commits pushed to the master branch:

• 4fea31ec03e2afe1116438e88f4875898c32c2f6: 8328242: Add a log area to the PassFailJFrame
• 31467103b9fbc8458e383495d80be0ee666608e4: 8323562: SaslInputStream.read() may return wrong value
• 3660c07f5ad83e0f1b26a8ccd1e3244189165ba6: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
• a6b9bfefb9a71c0adfa40ed8d31b5bcfa139ef14: 8321543: Update NSS to version 3.96
• a236389838c7e6784d68dfa0a41378a7ebb07197: 8328402: Implement pausing functionality for the PassFailJFrame
• 24e2c8a9e0ee3bea1d209a1db10ce07905adb2f8: 8315097: Rename createJavaProcessBuilder
• 48f0fa31318c063586ca4658a0ac3fc82f34aa4f: 8341806: Gcc version detection failure on Alinux3
• 94eaaa81eb62032b1a9df122d22774765236b247: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• b6685aa801ed48dea08679639159380e4ff00e9d: 8341997: Tests create files in src tree instead of scratch dir
• 56c03a4a4244c822eec9a45a037465d383a8fafe: 8273914: Indy string concat changes order of operations
• ... and 247 more: https://git.openjdk.org/jdk17u-dev/compare/e49367bba1733eaad374c152e04e2af322956466...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 00: Full (2b62a170)

[sendaoYan]

/approval request Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.

[openjdk[bot]]

@sendaoYan 8327474: The approval request has been created successfully.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Hi, can anyone take look tihs PR.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/clean

[openjdk[bot]]

@sendaoYan The /clean pull request command is not enabled for this repository

[sendaoYan]

Clean besides omission of one file

Thanks for the review.

/integrate

[openjdk[bot]]

@sendaoYan Your change (at version 2b62a170cff588716da6eaec7aea689fbdf1114a) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk[bot]]

Going to push as commit 498d2364f1062a8df66045067d63ad68c2aacc1c. Since your change was applied there have been 271 commits pushed to the master branch:

• 4d147bf2c7cd47d8c4c406fdd8393f34b6fe865b: 8328379: Convert URLDragTest.html applet test to main
• c436edbefd4bc99e67e4b82aee92f7eeb77aa037: 8342962: [s390x] TestOSRLotsOfLocals.java crashes
• af17bf4ca87f1fb588fc9e714108cf8b129f4340: 8283214: [macos] Screen magnifier does not show the magnified text for JComboBox
• e52902ee462650d601202d674637f81ccfeb6cec: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
• 467231b68a9a7d38552f261994a44faca19a71fe: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
• a72e14af66c6625d2f6269938502f46dc9718ce8: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color
• 70a227fe5a223939b95675e019c6f3db23b38755: 8333824: Unused ClassValue in VarHandles
• 9cf4adb844cea86c0e86446dc6f8766b0c843f17: 8319651: Several network tests ignore vm flags when start java process
• 808c5cd1edbdaccb661547ed3331c028dd039960: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 6b4544c0329c0b0000e1c5c121a91c8631782077: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• ... and 261 more: https://git.openjdk.org/jdk17u-dev/compare/e49367bba1733eaad374c152e04e2af322956466...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@GoeLin @sendaoYan Pushed as commit 498d2364f1062a8df66045067d63ad68c2aacc1c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.