jdk17u-dev 8302800: Augment NaN handling tests of FDLIBM methods

Backport of JDK-8302800

This PR contains two PR
commit 1 is made by the git apply which is clean
commit 2 adds the missing file test/jdk/java/lang/Math/InverseTrigTests.java currently does not exist in jdk17u-dev, it was originally added by JDK-8302026 via commit

Testing

Local: Test passed on MacOS 14.5 on Apple M1 Max
- CubeRootTests.java: Test results: passed: 1
- Expm1Tests.java: Test results: passed: 1
- HyperbolicTests.java: Test results: passed: 1
- Log10Tests.java: Test results: passed: 1
- Log1pTests.java: Test results: passed: 1
- Tests.java: Not applicable: not a test
- InverseTrigTests.java: Test results: passed: 1
Pipeline:
Testing Machine:

Progress

[ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue
[ ] JDK-8302800 needs maintainer approval

Issue

JDK-8302800: Augment NaN handling tests of FDLIBM methods (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2779/head:pull/2779
$ git checkout pull/2779

Update a local copy of the PR:
$ git checkout pull/2779
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2779

View PR using the GUI difftool:
$ git pr show -t 2779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2779.diff

Webrev

Link to Webrev Comment

Aug 03 '24 00:08 amosshi

:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Aug 03 '24 00:08 bridgekeeper[bot]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302800: Augment NaN handling tests of FDLIBM methods

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 245 new commits pushed to the master branch:

be4f913efab46b601f7cc472d654b4da883df152: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
8dbd6772f9b65ab1ae6ef683c7300092e4745951: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
c10340918cfe6d316c1d4d57e9f586c94c6d3098: 8308891: TestCDSVMCrash.java needs @requires vm.cds
d12077dc7d92eac99da9ab40c19a01b48f5dc121: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
6cbedd928985e9ddf8a370470c8ee9f4d5f0826b: 8273216: JCMD does not work across container boundaries with Podman
d5d26be717f5540de73e9d411d324f870d3d224b: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
2e3ca3149709f40996eac5fe96021cac259b29c2: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
27c92b6d50cf30bb08fe7829d4a3bce3f5b3f390: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
61e0a11132d4d85986b9f5d91439cc6f28ca03c7: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
698f0e37746bffe61fc59cd553d3582d0e004097: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
... and 235 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Aug 03 '24 00:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

Aug 03 '24 00:08 openjdk[bot]

Webrevs

00: Full (68f74209)

Aug 03 '24 00:08 mlbridge[bot]

JDK-8302026 which contains the 'missing' InverseTrigTests.java test was never backported to 17 so please check again that the test is really stable.

Aug 08 '24 13:08 MBaesken

Hi @MBaesken ,

FYI: we have monitored the test case for another week, so far so good, all passed:

Started at 2024-08-15 00:54:43+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [01:00:38.234 -> 578 msec]
Started at 2024-08-13 22:27:17+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [22:41:57.003 -> 3,551 msec]
Started at 2024-08-12 09:51:13+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [09:57:48.239 -> 119 msec]
Started at 2024-08-11 22:25:03+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [22:39:57.485 -> 454 msec]
Started at 2024-08-09 23:02:03+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [23:16:11.723 -> 577 msec]
Started at 2024-08-09 18:38:52+01:00
- Automated jtreg test: jtreg_jdk_tier1
- java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [18:53:29.160 -> 515 msec]

Regards Amos A Happy Developer

Aug 16 '24 01:08 amosshi

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Aug 16 '24 07:08 openjdk[bot]

/approval request "Backporting for parity with 17.0.13-oracle. No risk, test fix. Un-Clean backport. Test passes and SAP nightlies pass on 2024-08-07,15”

Aug 17 '24 03:08 amosshi

@amosshi 8302800: The approval request has been created successfully.

Aug 17 '24 03:08 openjdk[bot]

There are red tests, what is wrong?

Aug 21 '24 08:08 GoeLin

There are red tests, what is wrong?

Reason

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Action

I will re-trigger

Aug 22 '24 00:08 amosshi

/integrate

Aug 26 '24 18:08 amosshi

Going to push as commit 803c2c27d88ee0948611f11f1d099d7fe5c7d593. Since your change was applied there have been 249 commits pushed to the master branch:

cd0bb4d31ee53947234c717782f9d9bf9b488986: 8310683: Refactor StandardCharset/standard.java to use JUnit
1887a80260abc7d5ef4fb70a7a7a740751fdb398: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
64ab2faaddb0e7a81dd0139dbb178ef31b1aa40e: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
97e4a9374922bd8fd84e1315f89b189669a7b6d0: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
be4f913efab46b601f7cc472d654b4da883df152: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
8dbd6772f9b65ab1ae6ef683c7300092e4745951: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
c10340918cfe6d316c1d4d57e9f586c94c6d3098: 8308891: TestCDSVMCrash.java needs @requires vm.cds
d12077dc7d92eac99da9ab40c19a01b48f5dc121: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
6cbedd928985e9ddf8a370470c8ee9f4d5f0826b: 8273216: JCMD does not work across container boundaries with Podman
d5d26be717f5540de73e9d411d324f870d3d224b: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
... and 239 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

Your commit was automatically rebased without conflicts.

Aug 26 '24 18:08 openjdk[bot]

@amosshi Pushed as commit 803c2c27d88ee0948611f11f1d099d7fe5c7d593.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Aug 26 '24 18:08 openjdk[bot]