jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test

Open lawrence-andrew opened this issue 3 years ago • 3 comments

  1. This test was failing due to yesno test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno
  2. PrintCheckboxManualTest.html file was missing
  3. Added os.family since test instruction says that its a linux and solair toolkit only test
  4. Removed Sysout & TestDialog class & added a better manual framework to show the instruction and test frame.

@shurymury


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8292271: Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9858/head:pull/9858
$ git checkout pull/9858

Update a local copy of the PR:
$ git checkout pull/9858
$ git pull https://git.openjdk.org/jdk pull/9858/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9858

View PR using the GUI difftool:
$ git pr show -t 9858

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9858.diff

lawrence-andrew avatar Aug 12 '22 17:08 lawrence-andrew

:wave: Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 12 '22 17:08 bridgekeeper[bot]

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Aug 12 '22 17:08 openjdk[bot]

@lawrence-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 07 '22 06:10 bridgekeeper[bot]

@lawrence-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Nov 04 '22 17:11 bridgekeeper[bot]