jdk 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

Split the java/util/stream/SpinedBufferTest.java test into two parts:

java/util/stream/SpinedBufferTest1.java has the first 6 test cases
java/util/stream/SpinedBufferTes2.java has the second 6 test cases

I couldn't figure out a way to set a larger timeout value for the entirety of java/util/stream/SpinedBufferTest.java and I saw that other folks solved this problem with testng tests by splitting the test into more parts.

This fix is being tested in my jdk-20+10 stress testing run.

Progress

[ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue

Issue

JDK-8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9845/head:pull/9845
$ git checkout pull/9845

Update a local copy of the PR:
$ git checkout pull/9845
$ git pull https://git.openjdk.org/jdk pull/9845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9845

View PR using the GUI difftool:
$ git pr show -t 9845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9845.diff

Aug 11 '22 20:08 dcubed-ojdk

/label add core-libs /label add hotspot-runtime

Aug 11 '22 20:08 dcubed-ojdk

:wave: Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Aug 11 '22 20:08 bridgekeeper[bot]

@dcubed-ojdk The core-libs label was successfully added.

Aug 11 '22 20:08 openjdk[bot]

@dcubed-ojdk The hotspot-runtime label was successfully added.

Aug 11 '22 20:08 openjdk[bot]

Webrevs

Aug 11 '22 20:08 mlbridge[bot]

I would like to propose an alternative separation based on types. We can split into four for refs, ints, longs, and doubles, each extending from the same abstract class with shared code.

Aug 16 '22 16:08 PaulSandoz

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

Reviewed-by: rriggs, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

8e8ee4b6f22657a7efba8d7998f3c309f334a086: 8292596: Make SymbolHashMap a ResourceHashtable
aa9b8f04bf74d5fa00f2b27895e7369abea3a930: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
f95ee7960328410551a6948053d1ff0ec3d8c53d: 8292566: Add reference to the java.nio.file package in java.nio package documentation
45c3e898ed538545921395372fe507e9111401e1: 8292316: Tests should not rely on specific JAR file names (jpackage)
db772276848f6ad2d4d13e892bcd0eb3123d030f: 8282684: Obsolete UseContainerCpuShares and PreferContainerQuotaForCPUCount flags
256b52387b7267c234f03aac19422e59a77d956f: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
e561933907bbab0a42f1796fa12f582b3a347312: 8292623: Reduce runtime of java.io microbenchmarks
dcd78020e4cd064061ac892c566c94fb744859c4: 8292708: Rename G1ParScanThreadState::flush to flush_stats
16593cf51c3d994ba4a6d28ab97e519dfd53f37b: 8292717: Clean up checking of testing requirements in configure
c59f9b374b4497ab385675b0019c3647e6cddbbb: 8287828: Fix so that one can select jtreg test case by ID from make
... and 106 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Aug 16 '22 19:08 openjdk[bot]

@PaulSandoz, @RogerRiggs and @shipilev - Thanks for the reviews. I'll take a look at splitting the test in a cleaner fashion. I don't write a lot of Java code so it'll be a little bit before I update again.

Aug 19 '22 19:08 dcubed-ojdk

@shipilev - Thanks for the re-review! You did so before I even asked for one. :-) I'll go thru your comments above.

Aug 22 '22 15:08 dcubed-ojdk

@shipilev - Thanks for the very fast re-review. I've tested this version on my MBP13. Doing another Mach5 Tier1 with all the other patches in this batch just as a sanity check.

Aug 22 '22 18:08 dcubed-ojdk

@RogerRiggs - Thanks for the re-review!

Aug 22 '22 19:08 dcubed-ojdk

/integrate

Aug 22 '22 19:08 dcubed-ojdk

Going to push as commit ab6988599cded028ebfc4c958bc9e88d1b365ad7. Since your change was applied there have been 118 commits pushed to the master branch:

54843b700a463e75cd23a23df8ec5dc73b80f105: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"
8a0c3e53d541395ac32d656ac64d20ca0b9a187c: 8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java
8e8ee4b6f22657a7efba8d7998f3c309f334a086: 8292596: Make SymbolHashMap a ResourceHashtable
aa9b8f04bf74d5fa00f2b27895e7369abea3a930: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
f95ee7960328410551a6948053d1ff0ec3d8c53d: 8292566: Add reference to the java.nio.file package in java.nio package documentation
45c3e898ed538545921395372fe507e9111401e1: 8292316: Tests should not rely on specific JAR file names (jpackage)
db772276848f6ad2d4d13e892bcd0eb3123d030f: 8282684: Obsolete UseContainerCpuShares and PreferContainerQuotaForCPUCount flags
256b52387b7267c234f03aac19422e59a77d956f: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
e561933907bbab0a42f1796fa12f582b3a347312: 8292623: Reduce runtime of java.io microbenchmarks
dcd78020e4cd064061ac892c566c94fb744859c4: 8292708: Rename G1ParScanThreadState::flush to flush_stats
... and 108 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

Your commit was automatically rebased without conflicts.

Aug 22 '22 19:08 openjdk[bot]

@dcubed-ojdk Pushed as commit ab6988599cded028ebfc4c958bc9e88d1b365ad7.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Aug 22 '22 19:08 openjdk[bot]

java/util/stream/boottest/java.base/java/util/stream/*SpinedBuffer* passed 30 times (5 tests x 6 configs) in each of two different Mach5 Tier1 job sets.

Aug 22 '22 19:08 dcubed-ojdk