openjdk
8373623: Refactor Serialization tests for Records to JUnit
Refactor TestNG tests to JUnit under the umbrella initiative of JDK-8307843. Fairly straight-forward mapping of annotations between the frameworks with some accommodations for differences in the Assert support.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8373623: Refactor Serialization tests for Records to JUnit (Sub-task - P4)
Reviewers
- Justin Lu (@justin-curtis-lu - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28804/head:pull/28804
$ git checkout pull/28804
Update a local copy of the PR:
$ git checkout pull/28804
$ git pull https://git.openjdk.org/jdk.git pull/28804/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28804
View PR using the GUI difftool:
$ git pr show -t 28804
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28804.diff
Using Webrev
:wave: Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@RogerRiggs This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8373623: Refactor Serialization tests for Records to JUnit
Reviewed-by: jlu
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 24 new commits pushed to the master branch:
- ad29642d8f4e8e0fb1223b14b85ab7841d7b1b51: 8351889: C2 crash: assertion failed: Base pointers must match (addp 344)
- ea6493c4e1de2bc9615beee389b2d335669dc542: 8373100: Genshen: Control thread can miss allocation failure notification
- 34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c: 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests
- ... and 21 more: https://git.openjdk.org/jdk/compare/4e9525ef3619b02e905f16b89261b82c70830f3a...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@RogerRiggs The following label will be automatically applied to this pull request:
-
core-libs
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Going to push as commit 1e357e9e976bfb0abc9d4e14bfb1572693622af8.
Since your change was applied there have been 43 commits pushed to the master branch:
- 817e3dfde9eaa467ea0dca9b70282e914cdde093: 8350711: [JMH] test Signatures.RSASSAPSS failed for 2 threads config
- a0dd66f92d7f8400b9800847e36d036315628afb: 8373630: r18_tls should not be modified on Windows AArch64
- b0b42e7eb14dbe04c9c00e8d1fda139a502f2120: 8373615: Improve HotSpot debug functions findclass() and findmethod
- ... and 40 more: https://git.openjdk.org/jdk/compare/4e9525ef3619b02e905f16b89261b82c70830f3a...master
Your commit was automatically rebased without conflicts.
@RogerRiggs Pushed as commit 1e357e9e976bfb0abc9d4e14bfb1572693622af8.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.