jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8355607: Convert binary cert files to base64

Open friedbyalice opened this issue 9 months ago • 5 comments

The choice of file extension comes from the extension of the existing .cer files that are already in the repository: there are already 30 PEM certificates with a .cer extension


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8355607: Convert binary cert files to base64 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24946/head:pull/24946
$ git checkout pull/24946

Update a local copy of the PR:
$ git checkout pull/24946
$ git pull https://git.openjdk.org/jdk.git pull/24946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24946

View PR using the GUI difftool:
$ git pr show -t 24946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24946.diff

friedbyalice avatar Apr 29 '25 11:04 friedbyalice

:wave: Welcome back friedbyalice! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 29 '25 11:04 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 29 '25 11:04 openjdk[bot]

@friedbyalice The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Apr 29 '25 11:04 openjdk[bot]

What is changed in these files? I still see the binary files.

rhalade avatar May 01 '25 04:05 rhalade

@friedbyalice This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 26 '25 07:06 bridgekeeper[bot]

@friedbyalice This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 21 '25 11:08 bridgekeeper[bot]