jdk 8342183: Update tests to use stronger algorithms and keys

Some tests are identified to use weak/legacy algorithms in the tests. If the test purpose is not to test with weak algorithms then these tests should be updated to use stronger algorithms. If the test uses a weak key, update as well.

Progress

[ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue

Issue

JDK-8342183: Update tests to use stronger algorithms and keys (Sub-task - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21578/head:pull/21578
$ git checkout pull/21578

Update a local copy of the PR:
$ git checkout pull/21578
$ git pull https://git.openjdk.org/jdk.git pull/21578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21578

View PR using the GUI difftool:
$ git pr show -t 21578

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21578.diff

Oct 18 '24 08:10 fguallini

:wave: Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Oct 18 '24 08:10 bridgekeeper[bot]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342183: Update tests to use stronger algorithms and keys

Reviewed-by: rhalade, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

1eccdfc62288b8baff950b7293ee931eab896298: 8343439: [JVMCI] Fix javadoc of Services.getSavedProperties
ea110c35f5429f1e1de57a301e2256f508a4c324: 8343236: Use @apiNote and @implSpec in j.util.Currency
5995786dbd69ed11dd1cacb2a3ac86e3e6f43ab7: 8343177: JFR: Remove critical section for thread id assignment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade, @ascarpino) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Oct 18 '24 08:10 openjdk[bot]

@fguallini The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Oct 18 '24 08:10 openjdk[bot]

Webrevs

Oct 29 '24 09:10 mlbridge[bot]

Wherever you have added a stronger algorithm to test is fine with me. But in some tests, where possible, instead of replacing the weak algorithm, the test should be updated to run against weak and strong algorithm. For example, in test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java, test should be run with DES and AES algorithms. Changes to key size are fine.

Oct 30 '24 17:10 rhalade

The changes in this PR should not be integrated until https://github.com/openjdk/jdk/pull/21537 is integrated. The updates in SecurityUtils should be used from https://github.com/openjdk/jdk/pull/21537.

Oct 30 '24 18:10 rhalade

Thanks for updating PR with suggested changes. The updates look good to me. I recommend to wait for another reviewer (@ascarpino ?) to approve as well.

Nov 01 '24 15:11 rhalade

/integrate

Nov 01 '24 17:11 fguallini

@fguallini Your change (at version 948a14e1d81aa3af955b5e32fb3a3db5263c99b6) is now ready to be sponsored by a Committer.

Nov 01 '24 17:11 openjdk[bot]

/sponsor

Nov 01 '24 17:11 rhalade

Going to push as commit c82ad845e101bf5d97c0744377d68002907d4a0e. Since your change was applied there have been 3 commits pushed to the master branch:

1eccdfc62288b8baff950b7293ee931eab896298: 8343439: [JVMCI] Fix javadoc of Services.getSavedProperties
ea110c35f5429f1e1de57a301e2256f508a4c324: 8343236: Use @apiNote and @implSpec in j.util.Currency
5995786dbd69ed11dd1cacb2a3ac86e3e6f43ab7: 8343177: JFR: Remove critical section for thread id assignment

Your commit was automatically rebased without conflicts.

Nov 01 '24 17:11 openjdk[bot]

@rhalade @fguallini Pushed as commit c82ad845e101bf5d97c0744377d68002907d4a0e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Nov 01 '24 17:11 openjdk[bot]