jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8333403: Write a test to check various components events are triggered properly

Open ravigupta30 opened this issue 1 year ago • 7 comments

This testcase checks for the following assertions for Component events:

  1. When components are resized, moved, hidden and shown the respective events are triggered.
  2. When the components are hidden/disabled also,the component events like resized/moved are triggered.
  3. When a hidden component is hidden again, or a visible component is shown again, the events should not be fired.
  4. When a window is minimized/restored then hidden and shown component events should be triggered.

Testing: Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8333403: Write a test to check various components events are triggered properly (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19521/head:pull/19521
$ git checkout pull/19521

Update a local copy of the PR:
$ git checkout pull/19521
$ git pull https://git.openjdk.org/jdk.git pull/19521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19521

View PR using the GUI difftool:
$ git pr show -t 19521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19521.diff

Webrev

Link to Webrev Comment

ravigupta30 avatar Jun 03 '24 12:06 ravigupta30

:wave: Welcome back rgupta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 03 '24 12:06 bridgekeeper[bot]

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333403: Write a test to check various components events are triggered properly

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1303 new commits pushed to the master branch:

  • 6c91a16f16cbeb1bb0a79459e7db1fd9f576e743: 8340367: Opensource few AWT image tests
  • 865d99f63475799b9a0503a3dcc21a7534b014d1: 8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c
  • 3411f9dff79c2e7cb7ce8ebf036f8b3fd9bb647d: 8339995: Open source several AWT focus tests - series 6
  • 40cde003e8061a0eb6b0214d5a44325c3d55cdc6: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow
  • c8ae8480496d56a8e51b9f5a6df50c70a429672f: 8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683
  • cd796e0aef321d46c96f79dc5446d095b8a30e60: 8338918: Remove non translated file name from WinResources resource bundle
  • e97f0fe1b4046bfcc40e85ba1bee4f4c40053300: 8340365: Position the first window of a window list
  • 8dcf7b8fa7b17bf34c62c561c6ed78e8080df1ff: 8340411: open source several 2D imaging tests
  • 833ff29983e0d433ccd4c7e946b15e42045faeaa: 8340461: Amend description for logArea
  • c6f1d5f374bfa9bde75765391d5dae0e8e28b4ab: 8319332: Security properties files inclusion
  • ... and 1293 more: https://git.openjdk.org/jdk/compare/75220da26f647c6f3dabc05cea81cefaf3a1e195...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonGuy, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Jun 03 '24 12:06 openjdk[bot]

@ravigupta30 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jun 03 '24 12:06 openjdk[bot]

Copyright is missing. Please add the Copyright.

lawrence-andrew avatar Jun 04 '24 05:06 lawrence-andrew

@DamonGuy
I have tried on Windows with different scaling , works fine for me .

ravigupta30 avatar Jun 28 '24 04:06 ravigupta30

any volunteer for review?

ravigupta30 avatar Jul 02 '24 05:07 ravigupta30

@ravigupta30 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 02 '24 17:09 bridgekeeper[bot]

any volunteer for review?

ravigupta30 avatar Sep 04 '24 04:09 ravigupta30

moved test to java/awt/Component

ravigupta30 avatar Sep 18 '24 16:09 ravigupta30

I ran CI job with the latest code it passes without failure.

ravigupta30 avatar Sep 24 '24 04:09 ravigupta30

/integrate

ravigupta30 avatar Sep 24 '24 04:09 ravigupta30

@ravigupta30 Your change (at version fe35276b9185f2ac4cd54d73cecb0904c9dfb5d5) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Sep 24 '24 04:09 openjdk[bot]

/sponsor

aivanov-jdk avatar Sep 26 '24 16:09 aivanov-jdk

Going to push as commit a02d895f7ad59fe33f8a761dbd7bceb0b8dfefc0. Since your change was applied there have been 1360 commits pushed to the master branch:

  • bb040ef4cc2b626f282cbf6af5b359d1c2505385: 8340983: Use index and definition tags in Object and Double
  • 8225a5f58a62ddf4acbb879bfcb53cf7bfd8542f: 8340981: Update citations to "Hacker's Delight"
  • aceae76fb5853ab65851225aeb35a425af8f7af8: 8339460: CDS error when module is located in a directory with space in the name
  • aeaa4f78ebd634c2020d0f0dd100fcb55d5130af: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer
  • 376056ca48fb5dbe3d57cea01a9fbf2ea4c35616: 8336468: Reflection and MethodHandles should use more precise initializer checks
  • e36ce5f0341e8d0ec06cb12d0b2c0aa084401021: 8336942: Improve test coverage for class loading elements with annotations of different retentions
  • 95d3e9d199600bac0284f9151b99aef152e027ac: 8339560: Unaddressed comments during code review of JDK-8337664
  • 47fcf5a3b0796ffeb6407be961ceb552ca2a40f8: 8340687: Open source closed frame tests #1
  • 777c20cb14010b6726834246ae4c61bc4ccb3f9b: 8339542: compiler/codecache/CheckSegmentedCodeCache.java fails
  • 3762ec3978bfe9910929ab22aaf238e9f4c84630: 8340466: Add description for PassFailJFrame constructors
  • ... and 1350 more: https://git.openjdk.org/jdk/compare/75220da26f647c6f3dabc05cea81cefaf3a1e195...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 26 '24 16:09 openjdk[bot]

@aivanov-jdk @ravigupta30 Pushed as commit a02d895f7ad59fe33f8a761dbd7bceb0b8dfefc0.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 26 '24 16:09 openjdk[bot]