openjdk
8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
Hi, Can you help to review this patch? For vector shift instruct, some corresponding tests are not enabled, this is to enable them. And the way how vector shift instruct works is not clear, especially both vectorization (SLP in jdk) and Vector API share the same instruct's in riscv_v.ad, so also added some comment to clarify it.
Thanks
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19265/head:pull/19265
$ git checkout pull/19265
Update a local copy of the PR:
$ git checkout pull/19265
$ git pull https://git.openjdk.org/jdk.git pull/19265/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19265
View PR using the GUI difftool:
$ git pr show -t 19265
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19265.diff
Webrev
:wave: Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Hamlin-Li This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
Reviewed-by: fyang
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 85 new commits pushed to the master branch:
- 5f2b8d0224868d09ff54e93fabe4a6db177aef8f: 8332448: Make SpaceMangler inherit AllStatic
- 8a49d47cf3e845ddccaaeafeee9dfe6ab3180ded: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
- ce99198e3a6dc81865c518b1fe4a67e93b8ebdd1: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
- f5ab7dff402a3152f5d5736cc6521b4be617eccf: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
- 9f7779305c4ccbb86bb0e6d0ed8bc92a4b8f3b9d: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
- fb45bab8e15d7dc59fe801922d768d377d3f44cd: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
- 6e805127f8091d46205165746d7c59a40703958d: 8332545: Fix handling of HTML5 entities in Markdown comments
- b78613b6813a85662fb2af2004d0b68002fe471d: 8332154: Memory leak in SynchronousQueue
- 7652f9811bfddf08650b0c3277012074873deade: 8331885: C2: meet between unloaded and speculative types is not symmetric
- d6b7f9b170b6ce4f7275cc7595b71b9a3e93c133: 8331851: Add specific regression leap year tests for Calendar.roll()
- ... and 75 more: https://git.openjdk.org/jdk/compare/d517d2df451e135583083ed3684d7d3241b36f76...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@Hamlin-Li The following label will be automatically applied to this pull request:
-
hotspot-compiler
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 03: Full - Incremental (2ba613fa)
- 02: Full - Incremental (7216d886)
- 01: Full - Incremental (809f92e9)
- 00: Full (0078c854)
Yes, the tests passed.
Thanks @RealFYang @luhenry for your reviewing.
/integrate
Going to push as commit 5cf8288b8071bdcf0c923dd7ba36f91bc7594ef3.
Since your change was applied there have been 93 commits pushed to the master branch:
- ae9ad862ee54e119553efec919f1061dca36b954: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
- 3479b46c5bea3afd92b6ab4acd2fe7f274df38aa: 8332595: Serial: Remove unused TenuredGeneration::should_collect
- 9bfae8891e6efa58c557bd6dac61de111a16f71e: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
- 4e169d1ed7501d1de8fd4ea326f84b6c1a34270d: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
- 7ffc9997bd4a93cefe30f672a5f0e9c49215d2c7: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
- e529101ea30b49a6601088ce5ab81df590fc52f0: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
- 414a7fdc5e4aae4cec25b0847bb7c163f271b4e0: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl
- 451cc239050f097060be927171fe0e46962f3356: 8332486: ClassFile API ArrayIndexOutOfBoundsException with label metadata
- 5f2b8d0224868d09ff54e93fabe4a6db177aef8f: 8332448: Make SpaceMangler inherit AllStatic
- 8a49d47cf3e845ddccaaeafeee9dfe6ab3180ded: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
- ... and 83 more: https://git.openjdk.org/jdk/compare/d517d2df451e135583083ed3684d7d3241b36f76...master
Your commit was automatically rebased without conflicts.
@Hamlin-Li Pushed as commit 5cf8288b8071bdcf0c923dd7ba36f91bc7594ef3.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.