jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8328263: JMX Monitor should migrate to storing a Subject, not AccessControlContext

Open kevinjwalls opened this issue 1 year ago • 3 comments

A Monitor holds the AccessControlContext in which it was started. This should change to hold the Subject, and may be null.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8328263: JMX Monitor should migrate to storing a Subject, not AccessControlContext (Enhancement - P4)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 23, a new backport will be created when this pr is integrated.)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18490/head:pull/18490
$ git checkout pull/18490

Update a local copy of the PR:
$ git checkout pull/18490
$ git pull https://git.openjdk.org/jdk.git pull/18490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18490

View PR using the GUI difftool:
$ git pr show -t 18490

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18490.diff

kevinjwalls avatar Mar 26 '24 14:03 kevinjwalls

:wave: Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 26 '24 14:03 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 26 '24 14:03 openjdk[bot]

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 26 '24 14:03 openjdk[bot]

@kevinjwalls This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 21 '24 19:05 bridgekeeper[bot]

@kevinjwalls this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8328263_JMXMonitor_ACC_to_Subject
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar Jun 24 '24 05:06 openjdk[bot]

Closing, will redo.

kevinjwalls avatar Jun 24 '24 09:06 kevinjwalls