jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8327840: Automate javax/swing/border/Test4129681.java

Open TejeshR13 opened this issue 1 year ago • 4 comments

Automated the Test javax/swing/border/Test4129681.java from manual as suggested in JBS description. Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8327840: Automate javax/swing/border/Test4129681.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18336/head:pull/18336
$ git checkout pull/18336

Update a local copy of the PR:
$ git checkout pull/18336
$ git pull https://git.openjdk.org/jdk.git pull/18336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18336

View PR using the GUI difftool:
$ git pr show -t 18336

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18336.diff

Webrev

Link to Webrev Comment

TejeshR13 avatar Mar 16 '24 07:03 TejeshR13

:wave: Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 16 '24 07:03 bridgekeeper[bot]

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327840: Automate javax/swing/border/Test4129681.java

Reviewed-by: abhiscxk, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

  • 771f6a2f8e236e224b0e33b89f664c4bfc49e595: 8327704: Update nsk/jdi tests to use driver instead of othervm
  • 4210e507a0e65de00fab50e0584aa82cd7b3bf27: 8320362: Load anchor certificates from Keychain keystore
  • ab183e437c18b445e9c022a4d74de818d4ccecbe: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ab28045d7785d948b2bce685f06043e8217961f4: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
  • ba05c6d0b6955a0c5110b75e709e2206961f9fec: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
  • fa823bd21c6676c67c42275efb59868200409b38: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
  • e81374e0501a8201dac701824d2e29f2cedfcdff: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • cc5cda558736ffeae2a4611d87dfe280b9a4eac3: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main
  • ef2bd5721316f208a458fecfffa02ec2c0ea7fe0: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
  • e66788c16563d343f6cccd2807a251ccc6f9b64a: 8325179: Race in BasicDirectoryModel.validateFileCache
  • ... and 89 more: https://git.openjdk.org/jdk/compare/c05f8c72239ed3f16ff0d13f4dba795731f9559f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 16 '24 07:03 openjdk[bot]

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 16 '24 07:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 16 '24 22:03 mlbridge[bot]

/integrate

TejeshR13 avatar Mar 22 '24 03:03 TejeshR13

Going to push as commit 177b8a241c11782b302607c0068b15b38112e67c. Since your change was applied there have been 104 commits pushed to the master branch:

  • da009214f19f73965495b8462c9dcff5db8ae7ae: 8320404: Double whitespace in SubTypeCheckNode::dump_spec output
  • 4d36c4adcc47630ddc7149c48c06dc8a93c1be5c: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
  • 0efd9dc09b969846f79fb8ca16ddf565117d52b6: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
  • 46809b396ca76210f7939c8edf5a8263c29d3ddb: 8324736: Invalid end positions for EMPTY_STATEMENT
  • f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
  • 771f6a2f8e236e224b0e33b89f664c4bfc49e595: 8327704: Update nsk/jdi tests to use driver instead of othervm
  • 4210e507a0e65de00fab50e0584aa82cd7b3bf27: 8320362: Load anchor certificates from Keychain keystore
  • ab183e437c18b445e9c022a4d74de818d4ccecbe: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ab28045d7785d948b2bce685f06043e8217961f4: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
  • ba05c6d0b6955a0c5110b75e709e2206961f9fec: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
  • ... and 94 more: https://git.openjdk.org/jdk/compare/c05f8c72239ed3f16ff0d13f4dba795731f9559f...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 22 '24 03:03 openjdk[bot]

@TejeshR13 Pushed as commit 177b8a241c11782b302607c0068b15b38112e67c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 22 '24 03:03 openjdk[bot]