8293174: Handle parallel class loading in Java
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8293174: Handle parallel class loading in Java
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10106/head:pull/10106
$ git checkout pull/10106
Update a local copy of the PR:
$ git checkout pull/10106
$ git pull https://git.openjdk.org/jdk pull/10106/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10106
View PR using the GUI difftool:
$ git pr show -t 10106
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10106.diff
:wave: Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@coleenp The following labels will be automatically applied to this pull request:
-
core-libs -
hotspot-runtime
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
So I decided that the synchronized/parallel loadClassInternal logic shouldn't be in ClassLoader.java class which is a basic class and we're still investigating whether there's anything in the spec that mandates this synchronization, or if it's longstanding behavior that we've had. We may only want to support it for a limited time for compatibility. I moved the code to jdk.internal.loader.SynchronizedLoader. Having a single hashtable for all class loaders is more space efficient, and still mimics the JVM behavior because in the VM we used a single global PlaceholderTable, so not worse for performance.
@coleenp This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@coleenp This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.