crac icon indicating copy to clipboard operation
crac copied to clipboard

Ignore errors parsing classpath

Open rvansa opened this issue 2 years ago • 13 comments

This test is relevant mostly on Windows - trying to use URI in the form of file:/C:/path/to/... as classpath element. On Linux, this is parsed as two items as File.pathSeparator is :. However on Windows the second colon triggers an exception.


Progress

  • [x] Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/149/head:pull/149
$ git checkout pull/149

Update a local copy of the PR:
$ git checkout pull/149
$ git pull https://git.openjdk.org/crac.git pull/149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 149

View PR using the GUI difftool:
$ git pr show -t 149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/149.diff

Webrev

Link to Webrev Comment

rvansa avatar Dec 15 '23 09:12 rvansa

:wave: Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Dec 15 '23 09:12 bridgekeeper[bot]

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Ignore errors parsing classpath

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the crac branch:

  • 93000a3cbf357983f9f74b5a15b1efd33f272368: Adjusting CRaC tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

openjdk[bot] avatar Dec 15 '23 09:12 openjdk[bot]

Webrevs

mlbridge[bot] avatar Dec 15 '23 09:12 mlbridge[bot]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jan 12 '24 11:01 bridgekeeper[bot]

@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Mar 15 '24 13:03 bridgekeeper[bot]

/open

rvansa avatar Mar 18 '24 07:03 rvansa

@rvansa This pull request is now open

openjdk[bot] avatar Mar 18 '24 07:03 openjdk[bot]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 15 '24 12:04 bridgekeeper[bot]

/open

rvansa avatar Apr 17 '24 06:04 rvansa

@rvansa This pull request is already open

openjdk[bot] avatar Apr 17 '24 06:04 openjdk[bot]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 15 '24 10:05 bridgekeeper[bot]

@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jun 12 '24 11:06 bridgekeeper[bot]

@rvansa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 10 '24 17:07 bridgekeeper[bot]

@rvansa This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 07 '24 22:08 bridgekeeper[bot]