authzen icon indicating copy to clipboard operation
authzen copied to clipboard

Boxcarring

Open alexolivier opened this issue 1 year ago • 3 comments

  • Moves existing app and backend into a spec-1.0 folder
  • Extended application with boxcarring introduced in spec-1.1 folder
  • Added v1.0 and v1.1 sections into documentation site

alexolivier avatar Aug 13 '24 10:08 alexolivier

Deploy request for authzen-todo rejected.

Name Link
Latest commit 2560988004456e39ec42475f36f7b3212cbcf268

netlify[bot] avatar Aug 13 '24 10:08 netlify[bot]

@alexolivier I merged main into your branch. I had made some minor text edits on the API spec.

davidjbrossard avatar Aug 13 '24 16:08 davidjbrossard

For authzen-todo-application, I agree that we need two different apps, unless we add some kind of selector in the app that tells us which behavior we want. So I think the work you did here makes sense.

I can certainly do this - thinking some sort of feature toggle - but I will need to refactor it quite a bit which I'm happy to do if you are OK with it.

For authzen-todo-backend, I'm torn. Seems like adding another route (DELETE /todos) could be done in an additive way to the existing todo backend project. I like the middleware you created - I think you could just add it to the existing project without breaking anything?

That makes sense - I'll merge the backends

alexolivier avatar Aug 20 '24 10:08 alexolivier

backends merged but frontends are kept separate by version for now

alexolivier avatar Aug 21 '24 11:08 alexolivier

@alexolivier great work!

Given our recent spec changes, can you please update the PR to use an array for evaluations, and also the payloads for subject and resource should have subject.userID -> subject.properties.userID, and resource.ownerID -> resource.properties.ownerID.

ogazitt avatar Sep 14 '24 23:09 ogazitt

Awesome work you two, thanks for pulling this together.

On Sun, Sep 15, 2024 at 1:48 AM Omri Gazitt @.***> wrote:

@alexolivier https://github.com/alexolivier great work!

Given our recent spec changes, can you please update the PR to use an array for evaluations, and also the payloads for subject and resource should have subject.userID -> subject.properties.userID, and resource.ownerID -> resource.properties.ownerID.

— Reply to this email directly, view it on GitHub https://github.com/openid/authzen/pull/131#issuecomment-2351225908, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPRFP5Y57XTRYSOQRHXSF3ZWTDNHAVCNFSM6AAAAABMN7MXVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGIZDKOJQHA . You are receiving this because you commented.Message ID: @.***>

--

David Brossard http://www.linkedin.com/in/davidbrossard http://twitter.com/davidjbrossard http://about.me/brossard

Stay safe on the Internet: IC3 Prevention Tips https://www.capefearnetworks.com/wp-content/uploads/2017/05/Internet-Fraud-Prevention-Tips-IC3.pdf Prenez vos précautions sur Internet: https://cyber.gouv.fr/bonnes-pratiques-protegez-vous

davidjbrossard avatar Sep 15 '24 14:09 davidjbrossard

Given our recent spec changes, can you please update the PR to use an array for evaluations, and also the payloads for subject and resource should have subject.userID -> subject.properties.userID, and resource.ownerID -> resource.properties.ownerID.

Sure I'll pick this up next week when I'm back from PTO

alexolivier avatar Sep 17 '24 16:09 alexolivier

superseded by PR #156

ogazitt avatar Sep 26 '24 19:09 ogazitt