AppAuth-iOS icon indicating copy to clipboard operation
AppAuth-iOS copied to clipboard
verified publisher icon openid

Correct nullability annotations in OIDEndSessionRequest

Open philet opened this issue 3 years ago • 9 comments

Correct nullability annotations for OIDEndSessionRequest parameters idTokenHint, postLogoutRedirectURL, and state.

Fixes https://github.com/openid/AppAuth-iOS/issues/565

philet avatar Apr 08 '22 08:04 philet

@philet have you signed the contributor agreements?

petea avatar Apr 08 '22 17:04 petea

@petea I have signed them last Friday. Probably still needs to be processed on your side.

philet avatar Apr 11 '22 07:04 philet

@philet confirmed that we have the needed documentation from you, thanks.

petea avatar Aug 16 '22 19:08 petea

Since this will be a breaking change for the Swift interface, we'll need to make it as part of a major release.

petea avatar Aug 16 '22 20:08 petea

@petea since its only adding the nullability won't existing code still compile meaning its not a breaking change?

nbransby avatar Nov 04 '22 10:11 nbransby

We're having to run a fork of this lib because of this issue. Is there anything missing from the PR that we could provide?

pfei5 avatar Jan 30 '23 11:01 pfei5

Any update on this?

matax87 avatar Aug 07 '23 11:08 matax87