openhpc
Fix OHPC_macros rpmlint error
Use of $RPM_SOURCE_DIR or %{_sourcedir} is now treated as an error by rpmlint. Red Hat has codified it as an error: "Packages which use files itemized as Source# files, must refer to those files by their Source# macro name, and must not use $RPM_SOURCE_DIR or %{sourcedir} to refer to those files."
Most importantly, OpenHPC packaging shouldn't fail rpmlint and require exceptions to pass a basic check.
It's an easy fix that can be done with a global search and replace: Take the Source42 declaration out of OHPC_macros. Replace all "%includes %{_sourcedir}/OHPC_macros" and variants with Source42: OHPC_macros %includes %{SOURCE42}
This seems to be the "official" format for external spec includes.
Given the number files to be updated, I'm adding it as an issue first instead of creating a PR.
The fix above is the quick fix, but I think it's the wrong fix. OHPC_macros is not a source file--it's chunk of the specfile. The correct way to fix this is to symlink OHPC_macros under SPECS and just use "%include %{_specdir}/OHPC_macros".
I'm happy to create a PR, but we should discuss first, considering how many files are impacted.