Make service and app labels homogeneous across arnold applications

[madmatah]

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.

By convention, our kubernetes services have service and app labels. They should be consistent with the directory structure.

I.e. objects declared in apps/my-app/templates/services/my-service should have the following labels :

  app: my-app
  service: my-service

This convention is not applied homogeneously across arnold applications.

Describe the solution you'd like

Check all arnold applications to apply this convention.

Additional informations

Here is a first list of "suspects" service labels :

$ for a in apps/* ; do app=$(echo $a | cut -d/ -f2); for s in "apps/$app/templates/services/"* ; do svc=$(echo "$s" | cut -d/ -f5); grep -R "service\: " "apps/$app/templates/services/$svc" | grep -vE "service: [\"]?$svc[\"]?" | grep -vE "[^[:space:]]+service:" | grep -v "{{ service_variant }}" ; done ; done 
apps/edxapp/templates/services/lms/secret_git_sshkey.yml.j2:    service: "cms"
apps/edxec/templates/services/app/dc.yml.j2:    service: edxec
apps/edxec/templates/services/app/dc.yml.j2:        service: edxec
apps/edxec/templates/services/app/svc.yml.j2:    service: edxec
apps/edxec/templates/services/app/job_00_collectstatic.yml.j2:    service: edxec
apps/edxec/templates/services/app/job_00_collectstatic.yml.j2:        service: edxec
apps/edxec/templates/services/app/job_01_db_migrate.yml.j2:    service: edxec
apps/edxec/templates/services/app/job_01_db_migrate.yml.j2:        service: edxec
apps/forum/templates/services/app/secret.yml.j2:    service: forum
apps/forum/templates/services/app/dc.yml.j2:    service: forum
apps/forum/templates/services/app/dc.yml.j2:        service: forum
apps/forum/templates/services/app/svc.yml.j2:    service: forum
apps/forum/templates/services/app/bc.yml.j2:    service: "forum"
apps/forum/templates/services/app/is.yml.j2:    service: "forum"
apps/learninglocker/templates/services/app/job_db_migrate.yml.j2:    service: learninglocker
apps/learninglocker/templates/services/app/job_db_migrate.yml.j2:        service: learninglocker
apps/learninglocker/templates/services/app/svc_api.yml.j2:    service: api
apps/learninglocker/templates/services/app/job_storage.yml.j2:    service: learninglocker
apps/learninglocker/templates/services/app/job_storage.yml.j2:        service: learninglocker
apps/learninglocker/templates/services/app/svc_ui.yml.j2:    service: ui
apps/marsha/templates/services/app/secret.yml.j2:    service: marsha
apps/marsha/templates/services/app/dc.yml.j2:    service: marsha
apps/marsha/templates/services/app/dc.yml.j2:        service: marsha
apps/marsha/templates/services/app/job_db_migrate.yml.j2:    service: marsha
apps/marsha/templates/services/app/job_db_migrate.yml.j2:        service: marsha
apps/marsha/templates/services/app/svc.yml.j2:    service: marsha
apps/marsha/templates/services/app/job_collectstatic.yml.j2:    service: marsha
apps/marsha/templates/services/app/job_collectstatic.yml.j2:        service: marsha
apps/marsha/templates/services/app/secret_cloudfront_private_key.yml.j2:    service: "marsha"
apps/richie/templates/services/app/job_01_collectstatic.yml.j2:    service: richie
apps/richie/templates/services/app/job_01_collectstatic.yml.j2:        service: richie
apps/richie/templates/services/app/secret.yml.j2:    service: richie
apps/richie/templates/services/app/dc.yml.j2:    service: richie
apps/richie/templates/services/app/dc.yml.j2:        service: richie
apps/richie/templates/services/app/svc.yml.j2:    service: richie
apps/richie/templates/services/app/job_03_richie_init.yml.j2:    service: richie
apps/richie/templates/services/app/job_03_richie_init.yml.j2:        service: richie
apps/richie/templates/services/app/job_04_bootstrap_elasticsearch.yml.j2:    service: richie
apps/richie/templates/services/app/job_04_bootstrap_elasticsearch.yml.j2:        service: richie
apps/richie/templates/services/app/job_02_db_migrate.yml.j2:    service: richie
apps/richie/templates/services/app/job_02_db_migrate.yml.j2:        service: richie