openfga.dev icon indicating copy to clipboard operation
openfga.dev copied to clipboard

Add a check that rejects images a certain size (e.g. 5MB)

Open rhamzeh opened this issue 2 years ago • 7 comments

In a recent blog, we accidentally added an image that is too big (> 12MB), this downgrades the experience of the reader as they will not see the image and they will still be downloading a lot in the background.

To prevent this, we'd like to add an action that would block introducing new images that are > a predetermined size (5MB to start)

rhamzeh avatar Jan 29 '24 19:01 rhamzeh

@rhamzeh can you assing this to me.

sanibalakrishna avatar Jan 30 '24 04:01 sanibalakrishna

Thanks @sanibalakrishna! Assigned

rhamzeh avatar Jan 30 '24 11:01 rhamzeh

@rhamzeh Since there haven’t been any updates on this, could you please assign this issue to me?

rahulsunil2 avatar Sep 30 '24 18:09 rahulsunil2

Thanks @rahulsunil2 ! Assigned!

aaguiarz avatar Sep 30 '24 19:09 aaguiarz

@aaguiarz Thanks for assigning it to me. I’ve already raised a PR for this fix, as I was working on it in parallel after posting the comment. #857

rahulsunil2 avatar Sep 30 '24 19:09 rahulsunil2

If this issue is still open I would like to work on this, please assign it to me. Thank you

JanumalaAkhilendra avatar Oct 07 '24 09:10 JanumalaAkhilendra

Considering this issue is open, does it mean that it has not yet been solved?

samuelIkoli avatar Oct 16 '24 11:10 samuelIkoli