paragon icon indicating copy to clipboard operation
paragon copied to clipboard

fix: DataTable filter "Clear all" bug fix

Open kiram15 opened this issue 5 months ago • 3 comments

https://github.com/user-attachments/assets/550cfb6e-84e6-436b-9b7d-6ed18b9fb0dd

Description

There was a previous bug fix for the filters on DataTable, but this fix introduced a new bug where checkboxes were filtering correctly, but did not visually show as checked. This fix still provides correct functionality when clicking "Clear all" (all checkboxes get unchecked) but also fixes the new bug. The underlying issue was an empty array not being falsy in javascript.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • [ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • [ ] Does your change adhere to the documented style conventions?
  • [ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • [ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • [ ] Were your changes tested in the example app?
  • [ ] Is there adequate test coverage for your changes?
  • [ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • [ ] Verify your changes were released to NPM at the expected version.
  • [ ] If you'd like, share your contribution in #show-and-tell.
  • [ ] 🎉 🙌 Celebrate! Thanks for your contribution.

kiram15 avatar Aug 26 '25 22:08 kiram15