frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

feat: Make courseware URLs more human-readable

Open KristinAoki opened this issue 4 years ago • 1 comments

This PR updates the format of MFE URLs. Previously the URLs were extremely long and had repetitive information. This made it difficult for users to read and easily understand where they are within a course based on the URL. Now, the URL removes all the repetitive information and replaces it with a unique identifier. Updated all API call URLs with a decoded version of block id since unique identifier is being pulled from URL, but does not translate to any API in LMS.

This PR is connected to the edx-plarform PR-28174

KristinAoki avatar Jul 13 '21 17:07 KristinAoki

Codecov Report

Merging #540 (8882026) into master (71db431) will decrease coverage by 0.02%. The diff coverage is 83.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   84.24%   84.22%   -0.03%     
==========================================
  Files         219      219              
  Lines        3822     3904      +82     
  Branches      967      993      +26     
==========================================
+ Hits         3220     3288      +68     
- Misses        582      596      +14     
  Partials       20       20              
Impacted Files Coverage Δ
...-home/data/__factories__/outlineTabData.factory.js 100.00% <ø> (ø)
src/courseware/CoursewareRedirectLandingPage.jsx 0.00% <0.00%> (ø)
src/courseware/course/sequence/Sequence.jsx 88.42% <0.00%> (ø)
...eware/data/__factories__/courseMetadata.factory.js 100.00% <ø> (ø)
src/courseware/data/api.js 99.13% <ø> (ø)
src/index.jsx 0.00% <ø> (ø)
src/course-home/outline-tab/Section.jsx 78.26% <60.00%> (-5.95%) :arrow_down:
src/courseware/CoursewareContainer.jsx 86.09% <79.41%> (-1.77%) :arrow_down:
src/courseware/data/thunks.js 96.93% <94.44%> (-0.69%) :arrow_down:
src/course-home/data/api.js 84.94% <100.00%> (+0.08%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71db431...8882026. Read the comment docs.

codecov[bot] avatar Aug 02 '21 20:08 codecov[bot]

I'm gonna close this PR - it's definitely not going to be merged after all this time. Would still be nice to see something like this done eventually though.

bradenmacdonald avatar Apr 15 '25 20:04 bradenmacdonald