openedx
build: add start:with-theme command
Description
This changes fixes the ability to change the css theme when running the code locally. Previously the theme could be overridden via module.config.js, but at some point this option stopped working. Without running npm run start:with-theme there is no way to change the theme from the default openedX theme.
Thanks for the pull request, @KristinAoki!
This repository is currently maintained by @openedx/committers-frontend-app-learning.
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.09%. Comparing base (
81b6211) to head (837c488). Report is 56 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1633 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 338 338
Lines 5784 5784
Branches 1410 1410
=======================================
Hits 5211 5211
- Misses 556 557 +1
+ Partials 17 16 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@KristinAoki Can you rebase the PR, this seems to have a bunch of unrelated changes :)
Hey @farhaanbukhsh, when do you think you'll get around to reviewing this PR?
@farhaanbukhsh Would you prefer to hand the review for this PR off to someone else?
@itsjeyd, sorry for the delay. This somehow gets lost in the release work. It's done now.