frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

Clock icon in courseware sidebar does not follow conventions for notifications

Open aphilipharrell opened this issue 1 year ago • 5 comments

The clock icon in the courseware sidebar leads to a Notifications window - the clock icon is misleading and this should be replaced with something more commonly understood to represent notifications.

Suggested fix:

Replace WatchOutline with Notifications in src/courseware/course/sidebar/sidebars/notifications/NotificationIcon.jsx

aphilipharrell avatar Oct 30 '24 18:10 aphilipharrell

@arbrandes I assign it to myself

jciasenza avatar Nov 01 '24 17:11 jciasenza

Hello aphilipharrell, I already made the PR

https://github.com/openedx/frontend-app-learning/pull/1510

jciasenza avatar Nov 01 '24 19:11 jciasenza

@crathbun428 Can you please check if this request can be implemented? We can do it if approved.

angonz avatar Nov 08 '24 12:11 angonz

@angonz - There is potentially going to be some work done on the right-sidebar soon. I think thinking through what icons are shown will be apart of this work. I want to check in with @brian-smith-tcril and @jmakowski1123 to make sure I have this right.

crathbun428 avatar Nov 20 '24 13:11 crathbun428

Hi @aphilipharrell, just a heads-up that we ended up closing #1510 because it looked like someone had already made the same changes for Sumac.

So you might want to consider closing this issue, too.

CC @jciasenza @crathbun428

itsjeyd avatar Dec 19 '24 09:12 itsjeyd