openedx
Fix Untranslatable strings #1193
Fix: Untranslatable strings
Fixes #1193
What changed?
Add message ids and add a file src/instructor-toolbar/messages.js
Also modify the masquerade src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx
If you approve my changes I will push them, or if something needs to be modified let me know thanks !!! Atte Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing Documentation and test plan updated, if applicable Received code-owner approving review
- Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
I've done a visual code review
- I've tested the new functionality
FYI: @openedx/content-aurora
Thanks for the pull request, @jciasenza!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
@jciasenza Thank you for this contribution!
@openedx/committers-frontend-app-learning Could you please kick off a build for these changes?
Hey @jciasenza, just checking in to see if you're still planning to continue working on this PR?
Change useIntl instead of injectIntl
Channge: component form in a JSX context
@jciasenza It looks like there are some merge conflicts for you to resolve here. Let us know when you're done with that so we can schedule another round of review.
Hello Tim, I'm going to review it again and I'll let you know because I didn't find the error but as soon as I find it I'll let you know so that you can review it again, thank you!!!
De: Tim Krones @.> Enviado: jueves, 24 de octubre de 2024 5:29 Para: openedx/frontend-app-learning @.> Cc: Juan Carlos Iasenza @.>; Mention @.> Asunto: Re: [openedx/frontend-app-learning] Fix Untranslatable strings #1193 (PR #1449)
@jciasenzahttps://github.com/jciasenza It looks like there are some merge conflicts for you to resolve here. Let us know when you're done with that so we can schedule another round of review.
— Reply to this email directly, view it on GitHubhttps://github.com/openedx/frontend-app-learning/pull/1449#issuecomment-2434628858, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHTWIG63WBMJ4S2UIJ352FDZ5CVWNAVCNFSM6AAAAABNGWEGK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZUGYZDQOBVHA. You are receiving this because you were mentioned.Message ID: @.***>
Hello, farhaanbukhsh
I made a new PR, with this case since it brought me many conflicts when updating the master, I ask you to review the new one, thank you very much and let's close this PR #1506
closing this in favour of https://github.com/openedx/frontend-app-learning/pull/1505