frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard
verified publisher icon openedx

fix: masquerade dropdown not showing current selection

Open kaustavb12 opened this issue 1 year ago • 1 comments

Description

This PR fixes the issue where selecting "Specific Student..." masquerade option from the dropdown would not change the selected option in the dropdown.

Steps to recreate issue:

  1. Open course outline page for any course as a staff user.
  2. Ensure the masquerade option is currently set to "Staff".
  3. Select "Specifc Student.." option from the masquerade dropdown
  4. Open the drop down again and notice that "Specifc Student.." is NOT highlighted as selected.

Before: masquerade_selection_fix_before

After: masquerade_selection_fix_after

Testing instructions

Setup this PR branch in local or in a sandbox as usual.

  1. Open course outline page for any course as a staff user.
  2. Ensure the masquerade option is currently set to "Staff".
  3. Select "Specifc Student.." option from the masquerade dropdown
  4. Open the drop down again and that "Specifc Student.." is highlighted as selected.

Other information

Private Ref : OpenCraft Internal Ticket BB-9074

kaustavb12 avatar Aug 13 '24 05:08 kaustavb12

Thanks for the pull request, @kaustavb12!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Aug 13 '24 05:08 openedx-webhooks

@openedx/committers-frontend-app-learning Are you able to kick off a build for these changes or will we need to ask Axim to grant you the necessary permissions?

itsjeyd avatar Sep 07 '24 08:09 itsjeyd

@itsjeyd Just started the build :)

farhaanbukhsh avatar Sep 07 '24 09:09 farhaanbukhsh

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.48%. Comparing base (b9d1198) to head (86be66d). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tor-toolbar/masquerade-widget/MasqueradeWidget.jsx 88.88% 1 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   87.78%   88.48%   +0.69%     
==========================================
  Files         310      310              
  Lines        5320     5322       +2     
  Branches     1350     1350              
==========================================
+ Hits         4670     4709      +39     
+ Misses        633      596      -37     
  Partials       17       17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 07 '24 09:09 codecov[bot]

Thanks @farhaanbukhsh. Looks like it worked only partially -- I'm still seeing "7 successful and 1 expected checks" above. What needs to happen for the remaining checks to run?

CC @bradenmacdonald @mphilbrick211

itsjeyd avatar Sep 20 '24 13:09 itsjeyd

@kaustavb12 Please rebase the PR - somehow one of the CI checks got "stuck".

bradenmacdonald avatar Sep 20 '24 17:09 bradenmacdonald

PR rebased. All checks passed.

@itsjeyd @bradenmacdonald

kaustavb12 avatar Sep 23 '24 06:09 kaustavb12