frontend-app-learning icon indicating copy to clipboard operation
frontend-app-learning copied to clipboard

fix: increase subsection grades rounding precision

Open Agrendalath opened this issue 1 year ago • 5 comments

We used two decimal digits to match the experience from the edx-platform. However, https://github.com/openedx/edx-platform/pull/27788 increased the precision to reduce the impact of double rounding.

See the details and testing instructions at https://github.com/openedx/edx-platform/pull/27788.

Private-ref: BB-4210

Agrendalath avatar May 26 '24 23:05 Agrendalath

Thanks for the pull request, @Agrendalath!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar May 26 '24 23:05 openedx-webhooks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.78%. Comparing base (b9d1198) to head (0ac36ee). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1397   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files         310      310           
  Lines        5320     5320           
  Branches     1350     1316   -34     
=======================================
  Hits         4670     4670           
  Misses        633      633           
  Partials       17       17           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 26 '24 23:05 codecov[bot]

@Agrendalath Thank you for this contribution!

It looks like the older PR that you mentioned in the description (https://github.com/openedx/edx-platform/pull/27788) is tagged for product review. Should we do the same here?

CC @mphilbrick211

itsjeyd avatar Jun 06 '24 08:06 itsjeyd

@Agrendalath OK great, I'll add the product review label now.

itsjeyd avatar Jun 07 '24 08:06 itsjeyd

@Agrendalath It looks like you got the go-ahead from product!

I updated labels and Contribution board status of this PR and https://github.com/openedx/edx-platform/pull/27788 to reflect that.

Please ping @committers-frontend-app-learning for review when you're done working on the changes and the build is green :)

CC @mphilbrick211

itsjeyd avatar Sep 20 '24 12:09 itsjeyd

@openedx/committers-frontend-app-learning, could you please review and merge this?

Agrendalath avatar Sep 23 '24 11:09 Agrendalath