openedx
Convert discussion block's html from mako template into django template format
Description
In this PR i converted discussion's html files from mako into django template.
I converted following files. _discussion_inline.html _discussion_inline_studio.html _filter_dropdown.html _thread_list_template.html _underscore_templates.html discussion_board_fragment.html
Ticket Reference: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=106903650&issue=openedx%7Cedx-platform%7C36539
Acceptance criteria
- html template should be refactored to django template with minimal code changes
- Discussion XBlock experience shouldn't be changed
- All test cases should be passed on the edx-platform
How to test this PR
To enable discussion xblock:
tutor plugins install forum
tutor plugins enable forum
tutor dev do init -l forum
To show the builtin discussion xblock component on unit page:
- Go to studio admin site.
- Go into discussion configurations (/admin/discussions/discussionsconfiguration/)
- Update the provide to 'legacy'
To show the legacy discussion view from discussion tab:
- Go to studio admin site.
- Go into flags (/admin/waffle/flag/)
- disable this flag 'discussions.enable_discussions_mfe'
Testing results
Sanbox testing results.
Thanks for the pull request, @salman2013!
This repository is currently maintained by @openedx/wg-maintenance-edx-platform.
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Sandbox deployment failed 💥 Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. 📜 Failure Logs ℹ️ Grove Config, Tutor Config, Tutor Requirements
