openedx
fix: fixed styles for legacy xblock's editor
There is a problem with a styles for the legacy xblock's editor in CMS: https://github.com/openedx/frontend-app-authoring/issues/1904
Currently, styles are used there that correspond to legacy theme, not to paragon design system.
Main goal of this PR is tweak current styles for greater consistency with paragon, and fix some style bugs (input and textarea styles, button colors, border colors, hover and focus styles etc.)
Some of fixed xblock's editors for example:
Thanks for the pull request, @bydawen!
This repository is currently maintained by @openedx/wg-maintenance-edx-platform.
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hio @bydawen! Is this still in progress?
Hello, no, it's waiting for a review) Thanks!
Problem black
Before
After
Poll
Before
After
Content experiment
Before
After
Survey
Before
After
Open Response Assessment
Before
After
@PKulkoRaccoonGang hi there! Are you able to review this?
Hi @mphilbrick211! Sorry for the long delay. I’ve reviewed and approved this PR. Could you help move it forward by facilitating the merge or requesting a review from the right folks?
@mphilbrick211 Sure, but it might take me a while; I'm a bit behind on my reviews.
@bydawen this looks pretty close to landing once you respond to @bradenmacdonald 's feedback. Do you think you'll be able to do that soon?
@bydawen this looks pretty close to landing once you respond to @bradenmacdonald 's feedback. Do you think you'll be able to do that soon?
Hi @feanil i've answered to @bradenmacdonald above, thx!