edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

feat: REST API for create Library Collection [FC-0062]

Open ChrisChV opened this issue 1 year ago • 1 comments

Description

  • Adds a REST API view to create a new collection.
  • Fix issues in rebuild_index when indexing collections.

Supporting information

  • Github link: https://github.com/openedx/frontend-app-course-authoring/issues/1100
  • Internal ticket: FAL-3788
  • Used by: https://github.com/openedx/frontend-app-course-authoring/pull/1259

Testing instructions

  • Follow the testing instructions at https://github.com/openedx/frontend-app-course-authoring/pull/1259

ChrisChV avatar Sep 07 '24 18:09 ChrisChV

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Sep 07 '24 18:09 openedx-webhooks

I think we already have the event for LIBRARY_COLLECTION_CREATED. Should we implement the index update as part of this task?

@rpenido I added it here: https://github.com/openedx/edx-platform/pull/35447/commits/b7378ab3359e5395cf66969579a6498e05a25972

ChrisChV avatar Sep 09 '24 22:09 ChrisChV

@rpenido I just noticed that this API is being implemented here. I'm going to use that branch to avoid any conflicts.

ChrisChV avatar Sep 10 '24 16:09 ChrisChV

Closed in flavor of https://github.com/open-craft/edx-platform/pull/683

ChrisChV avatar Sep 10 '24 17:09 ChrisChV