openedx
Tag in Collections [FC-0062]
Description
Updates tagging_api to enable tags objects with LibCollectionKey as key.
Supporting information
- Github Issue: https://github.com/openedx/modular-learning/issues/228
- Depends on: https://github.com/openedx/opaque-keys/pull/335
- Internal ticket: https://tasks.opencraft.com/browse/FAL-3785
Testing instructions
- Check all the code
- Verify that the test covers the changes
Other information
-
Before merge: Bump version of
edx-opaque-keys
Thanks for the pull request, @ChrisChV!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
@rpenido Thanks for the review.
Could you add some tests for the view to check the permissions?
I'm unsure how to test that at the Python API level, as that has not been checked there. As far as I understand that permission is checked in openedx-learning rest_api, just like all other object types.
I'm unsure how to test that at the Python API level, as that has not been checked there. As far as I understand that, permission is checked in
openedx-learningrest_api, just like all other object types.
It is a bit of back-and-forth. The permission is checked in openedx-learning, but we override the permission rules here.
You updated this file, so I think the permission was updated.
Here we test tagging a course, a block and a library. I think we should also test tagging a collection.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.