edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

[DEPR]: discussions.pages_and_resources_mfe waffle flag

Open ormsbee opened this issue 1 year ago • 1 comments

Proposal Date

2024-08-08

Target Ticket Acceptance Date

2024-08-22

Earliest Open edX Named Release Without This Functionality

Sumac

Rationale

The target removal date was 2021-12-31, and this flag no longer really works in the sense that if you're in the MFE experience for Studio, you still get the new Pages and Resources UI regardless of the value of this flag.

Removal

CourseWaffleFlag "to enable new Pages and Resources experience for course".

https://github.com/openedx/edx-platform/blob/e7dbc4883c99bc1ff9c279c00ac6e47679bfc761/openedx/core/djangoapps/discussions/config/waffle.py#L23-L34

Replacement

No replacement–the MFE will always be enabled.

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

ormsbee avatar Aug 08 '24 17:08 ormsbee

We just stumbled onto a bug where the workaround was to temporarily turn off this waffle flag. I'd appreciate keeping the flag available until the bug is fixed or there is another, well-documented workaround.

I'll update this comment with a link to the bug once I've opened an issue.

pdpinch avatar Sep 06 '24 15:09 pdpinch

@pdpinch did you file that bug somewhere? can you link it here?

feanil avatar Sep 19 '24 19:09 feanil

Sorry about not getting back to this.

Here's the issue: https://github.com/openedx/edx-platform/issues/35509

It's very similar to another one for the discussion tab, which has a PR to fix it: https://github.com/openedx/edx-platform/pull/35431

pdpinch avatar Sep 19 '24 20:09 pdpinch

[inform] This DEPR is in the Draft state. It can't move forward without a DEPR coordinator to help update it to match the updated DEPR template. No action is required, unless anyone wants to move this out of Draft.

robrap avatar May 23 '25 20:05 robrap

Not sure if the bug Peter reported is still relevant so checking in on that, we'll figure out the timing and next steps after we figure that out.

feanil avatar May 30 '25 13:05 feanil