openedx
33589: Updated mako_block.py to use MakoService
Resolves https://github.com/openedx/edx-platform/issues/33589. Total of 12005 warnings will be removed according to the deprecated devstack action logs
The render_template check has been removed from constructor and there is no check explicitly implemented for existence of the 'mako' service. This should work because a check is already in place at xblock. The runtime class hierarchy is as follows: caching_descriptor_system.py -> x_module.py -> runtime.py
Thanks for the pull request, @abdullahQureshee!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Submit a signed contributor agreement (CLA)
:warning: We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation. Please see the CONTRIBUTING file for more information.
If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.
Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Update the status of your PR
Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hi @abdullahQureshee! Thank you for this contribution. When you have a moment, would you please put a description of your changes at the top of the pull request?
Please also let me know if you have any questions regarding submitting a CLA form. Thank you!
Hi @abdullahQureshee! Thank you for this contribution. When you have a moment, would you please put a description of your changes at the top of the pull request?
Please also let me know if you have any questions regarding submitting a CLA form. Thank you!
Sure. I'm currently doing some RnD on the issue. Once thats done, I'll create a proper PR. Right now its in Draft. I hope its ok to keep the Draft for a bit longer.
@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA?
Yes.
@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA?
Yes.
@abdullahQureshee - please have your manager send an email to [email protected] to have you added to the existing CLA. Let me know if you have any questions!
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.