edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

feat: meilisearch backend

Open qasimgulzar opened this issue 1 year ago • 4 comments

Added meilisearch searcher backend class in edx-platform to support meilisearch integration.

Reason why I implemented inside edx-platform.

  • As per this ADR edx-search is going to be depreceated soon.
################### Studio/LMS Search (beta), using Meilisearch ###################

# Enable Studio search features (powered by Meilisearch) (beta, off by default)
MEILISEARCH_ENABLED = True
# Meilisearch URL that the python backend can use. Often points to another docker container or k8s service.
MEILISEARCH_URL = "http://meilisearch:7700"
# URL that browsers (end users) can use to reach Meilisearch. Should be HTTPS in production.
MEILISEARCH_PUBLIC_URL = "http://localhost:7700"
# To support multi-tenancy, you can prefix all indexes with a common key like "sandbox7-"
# and use a restricted tenant token in place of an API key, so that this Open edX instance
# can only use the index(es) that start with this prefix.
# See https://www.meilisearch.com/docs/learn/security/tenant_tokens
MEILISEARCH_INDEX_PREFIX = "meilisearch_"
MEILISEARCH_API_KEY = "masterKey"
SEARCH_ENGINE = "search.meilisearch.MeiliSearchEngine"

By using new meilisearch backend I have successfully managed to index exisitng elasticsearch compatibale indexes to meilisearch.

image

qasimgulzar avatar Jun 24 '24 08:06 qasimgulzar

Thanks for the pull request, @qasimgulzar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar Jun 24 '24 08:06 openedx-webhooks

Hi @qasimgulzar! Just flagging that there's a failing check here. Would you mind taking a look? Thanks!

mphilbrick211 avatar Jun 24 '24 22:06 mphilbrick211

meilisearch is working with discover page image

qasimgulzar avatar Jul 09 '24 14:07 qasimgulzar

image

In last commit I have fixed the facets listing for meilisearch backend

qasimgulzar avatar Jul 10 '24 07:07 qasimgulzar

Hi @qasimgulzar! Just checking in to see if you are still planning to pursue this pull reqeust?

mphilbrick211 avatar Oct 30 '24 19:10 mphilbrick211

No more required this PR, implementation os moved to openedx api

qasimgulzar avatar Oct 30 '24 19:10 qasimgulzar