openedx
fix: let the platform decide to how login the users
We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login.
Close #34990
Thanks for the pull request, @CodeWithEmad!
This repository is currently maintained by @openedx/wg-maintenance-edx-platform.
Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Any idea? Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
Any idea? Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
Hi @CodeWithEmad! If needed, I can see if someone on the Axim team can help with this.
How is this different from using the setting ENABLE_REQUIRE_THIRD_PARTY_AUTH?
https://docs.openedx.org/projects/edx-platform/en/latest/references/featuretoggles.html#featuretoggle-ENABLE_REQUIRE_THIRD_PARTY_AUTH
I feel like there is a subtle difference, but I'm not sure.
Thanks for mentioning this. My change is related to the old theme, where it forces you to first go to the authn mfe if you have it enabled, no matter what. then, from there, it chooses to send you to either third-party authentication or not. the login URL will redirect you to the current address anyway. I hope it makes sense.
Hi @CodeWithEmad! Just flagging a new test has popped up. Then it looks like this can be reviewed again.