openedx
fix: disable submit button for archived courses
Description
This PR disables the submission button for problems in the archived courses.
Current behaviour: The learner can submit the problem in the archived courses which don't have a due date. The grade is recorded in the gradebook that should be closed.
After the PR merges: The submit button will be disabled and the learner cannot submit the problem.
Useful information to include:
- Which edX user roles will this change impact? "Learner"
- Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
Before
After
- Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions. Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
- Create a new course in studio.
- From settings dropdown, select
Schedule and Details. - Make the course
self-pacedand add the start date, end date, enrollment start, enrollment end dates to past. - Save the changes and return back to course outline.
- Create a section, subsection and a problem unit and publish it.
- In the subsection's settings, set the grading to
Homework - Go to the unit and click on
View Live Version. - Validate that the submit button is disabled.
Deadline
None
Other information
Include anything else that will help reviewers and consumers understand the change.
- Does this change depend on other changes elsewhere?
- Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
- If your database migration can't be rolled back easily.
Thanks for the pull request, @Anas12091101!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.
- If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
- If it doesn't, simply proceed with the next step.
:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
- Dependencies
This PR must be merged before / after / at the same time as ...
- Blockers
This PR is waiting for OEP-1234 to be accepted.
- Timeline information
This PR must be merged by XX date because ...
- Partner information
This is for a course on edx.org.
- Supporting documentation
- Relevant Open edX discussion forum threads
:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
- Overview of Review Process for Community Contributions
- Pull Request Status Guide
- Making changes to your pull request
When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
- The size and impact of the changes that it introduces
- The need for product review
- Maintenance status of the parent repository
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
We need to give some consideration to how this interacts with the past_due function. Based on what I understand from the course authors, they expect that a user who has been granted an extension on a problem due date would still be able to submit after the course end date.
Will this change affect all xBlocks, or just capa problems?
I believe it will only affect the capa problems
I've spoken with a number of experienced course authors and they all feel that this behavior is a bug that was introduced sometime in 2023. In the Olive release, learners could not submit answers after the course end date. Now in Quince they can.
Can you do some research in the git history and see if you can figure out when this change was introduced? Are there any tests for course end dates?
@pdpinch, I set up Olive locally using Tutor and tested this. Olive is also allowing submissions for problems in archived courses, with the difference that the gradebook doesn't get updated. If a course becomes archived after a submission, the gradebook is updated on the next submission. This seems more like a bug than a feature. A similar behavior was observed previously for the restricted course blocks and was solved in this PR by Asad Ali. I tried to further debug this but couldn't due to several errors in the Tutor release for Olive. The devstack provision command for Olive is also not working.
I've spoken with a number of folks about this, and they all agree that it's a bug.
Another area we should examine: edx-when. My understanding after discussing with @ormsbee is that the edx-when application manages a cached, customized version of course dates for users, particularly for self-paced courses where deadlines are shifted based on when the user starts the course.
@Anas12091101 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.
2U Release Notice: This PR has been deployed to the edX production environment.
2U Release Notice: This PR has been deployed to the edX production environment.