openedx
feat: support rendering XBlocks in the Learning MFE [FC-0035]
Rendering blocks directly in the MFE was developed for the Library Authoring MFE. The solution was then ported to the Learning MFE. This commit includes backend changes required to retrieve data of non-blockstore XBlocks from LMS.
Please see https://github.com/openedx/frontend-app-learning/pull/1281 for the details and testing instructions.
Other information
- https://github.com/aximcollaborative/funded-contributions/issues/15
- Private-ref: BB-7872
Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi @ormsbee and @arbrandes! Just checking in on this. I think we're waiting on this to close the project.
We've found that the Library Authoring approach to using an iframe per XBlock doesn't give users a good enough UX. See my comment in the PR that was meant to add the same approach to Course Authoring:
https://github.com/openedx/frontend-app-course-authoring/pull/964#pullrequestreview-2033590615
We're going to need a better plan if we want to stop using the backend to render whole units.
To be clear, this is not to say that this PR is wrong. We might find a frontend-only solution to the performance issues. But we should probably hold off here until we've had that conversation.
We've found that the Library Authoring approach to using an iframe per XBlock doesn't give users a good enough UX. See my comment in the PR that was meant to add the same approach to Course Authoring:
openedx/frontend-app-course-authoring#964 (review)
We're going to need a better plan if we want to stop using the backend to render whole units.
To be clear, this is not to say that this PR is wrong. We might find a frontend-only solution to the performance issues. But we should probably hold off here until we've had that conversation.
FYI @ormsbee @Agrendalath
Thank you for sharing it, @arbrandes. In this case, I suppose we should close this and https://github.com/openedx/frontend-app-learning/pull/1281 for now.
cc: @ormsbee, @mphilbrick211
@Agrendalath Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.