edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

fix: open new editors from non-unit Studio container page

Open ArturGaspar opened this issue 2 years ago • 53 comments

Make the edit button on a container page for a non-unit block (i.e. an individual text, problem or video block) open the new editor when the relevant flag is enabled.

Description

The Studio Course Container page "Edit" button goes to legacy editors. This pull request fixes that so it goes to the new editors.

Impacts Course Author users.

Testing instructions

  1. Enable the new editors (create waffle flags new_core_editors.use_new_text_editor, new_core_editors.use_new_problem_editor, new_core_editors.use_new_video_editor enabled for everyone).

  2. Find the block id.

    1. Click "Edit" on a block.

    2. See that you are redirected to the new editor.

    3. Find the block id from the last path component of the URL.

      • e.g. block-v1:edX+DemoX+Demo_Course+type@html+block@030e35c4756a4ddc8d40b95fbbfff4d4.
  3. Go to http://localhost:18010/container/[block id].

    • e.g. http://localhost:18010/container/block-v1:edX+DemoX+Demo_Course+type@html+block@030e35c4756a4ddc8d40b95fbbfff4d4.
  4. Click the "Edit" button on the top right of the page.

  5. See that you are redirected to the new editor.

Repeat for the 3 block types: text, problem, video.

Deadline

None

Other information

Private-Ref: BB-7941

ArturGaspar avatar Oct 24 '23 15:10 ArturGaspar

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Oct 24 '23 15:10 openedx-webhooks

@jristau1984 @cablaa77 This should resolve TNL-10884.

tecoholic avatar Oct 26 '23 13:10 tecoholic

@navinkarkera One more PR to label "jira:2u" :)

tecoholic avatar Nov 09 '23 10:11 tecoholic

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 10:11 open-craft-grove

I don't have a Jira project configured for this repo in the private 2U Jira. Contact Ned Batchelder (@nedbat) to set up a project.

openedx-webhooks avatar Nov 30 '23 10:11 openedx-webhooks

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 10:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 10:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 11:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 11:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 11:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 11:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 12:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 12:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 12:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 12:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 13:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 13:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 13:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 13:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 14:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 14:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 14:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 14:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 15:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 15:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 15:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 15:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 16:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 16:11 open-craft-grove

Sandbox destroy request received.

open-craft-grove avatar Nov 30 '23 16:11 open-craft-grove