edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard
verified publisher icon openedx

fix: save scroll position on exit from video xblock fullscreen mode

Open ihor-romaniuk opened this issue 3 years ago • 1 comments

This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.

Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.

Dependent PR to MFE Learning: This MR https://github.com/openedx/frontend-app-learning/pull/981 must be merged with this MR.

ihor-romaniuk avatar Sep 28 '22 15:09 ihor-romaniuk

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Sep 28 '22 15:09 openedx-webhooks

Hi @ihor-romaniuk! Just checking in on this to see if you plan on re-running the failing checks?

mphilbrick211 avatar Dec 16 '22 17:12 mphilbrick211

Hi @mphilbrick211. I have updated brunch and it's ready for review.

ihor-romaniuk avatar Dec 27 '22 14:12 ihor-romaniuk

Thanks @ihor-romaniuk! I will find someone to review.

mphilbrick211 avatar Dec 27 '22 17:12 mphilbrick211

@arbrandes @brian-smith-tcril - hi there! Would you mind reviewing this?

@jmakowski1123 - this should have a product review as well - please let me know who will be taking a look at it.

Thanks!

mphilbrick211 avatar Jan 13 '23 15:01 mphilbrick211

Friendly ping on this @jmakowski1123!

mphilbrick211 avatar Jan 23 '23 19:01 mphilbrick211

@jmakowski1123 and @ProductRyan flagging for you! Still needs product review :)

mphilbrick211 avatar Feb 07 '23 19:02 mphilbrick211

Hi @brian-smith-tcril Your comment was fixed. Also, additional information were added there https://github.com/openedx/platform-roadmap/issues/229 about fixes.

ihor-romaniuk avatar Mar 03 '23 10:03 ihor-romaniuk

@ProductRyan - is this good-to-go on your end?

mphilbrick211 avatar Mar 07 '23 01:03 mphilbrick211

4/5/23 - Product review complete.

@openedx/content-aurora @mattcarter - is this something you can take a look at? Other related PRs are #31871 #31055 and #31061. Thank you!

mphilbrick211 avatar Apr 05 '23 14:04 mphilbrick211

4/5/23 - Product review complete.

@openedx/content-aurora @mattcarter - is this something you can take a look at? Other related PRs are #31871 #31055 and #31061. Thank you!

Hi @mattcarter @openedx/content-aurora! Friendly ping on this.

mphilbrick211 avatar Apr 24 '23 23:04 mphilbrick211

Friendly ping on this @mattcarter and @openedx/content-aurora :)

mphilbrick211 avatar May 10 '23 18:05 mphilbrick211

@mattcarter @openedx/content-aurora re-flagging this.

mphilbrick211 avatar Jun 01 '23 18:06 mphilbrick211

Hi @leangseu-edx! Can you or someone from your team merge this for us?

mphilbrick211 avatar Jun 20 '23 18:06 mphilbrick211

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jun 21 '23 17:06 openedx-webhooks