fix: added keyword substitution support in edx_ace based bulk course emails
This PR has changes to support keyword substitution in edx_ace based bulk course emails. This issue is reported here.
Testing Instructions.
-
Login as a user having django admin access and enable bulk course email flag

-
Login as course instructor or staff
-
Open
Emailtab on instructor dashboard of any course -
Set Myself in
Send Tofield, enter anything inSubjectfield. InMessagefield enter the text below and hitSend Mailbutton
Hey %%USER_FULLNAME%%
welcome in %%COURSE_DISPLAY_NAME%%
- You should receive email with
%%USER_FULLNAME%%and%%COURSE_DISPLAY_NAME%%replaced with user's full name and the course display name.
Should anything be added in the UI to show users that this capability exists?
I assume preview is difficult/impossible (it was when I previously worked on bulk email in 2013), but that would be a good consideration for extension to validate that the variables are properly entered
Hi @ziafazal this feature is in a state of ownership limbo at 2U. Most recently my team worked on it but we will be transferring ownership to @jristau1984's team Infinity. My team also built a replacement for the front end which I don't think is fully supported in Open edX yet, and since we are transititioning ownership we don't have a current plan to address that. It might help to have a synchronous conversation about how to land this.
@sarina thanks for reviewing. I have
- added positive asserts in test
- added some text and docs link in UI if instructors need to know more about message
Keywords
@ziafazal I want to be clear that I don't know this code area well and don't own it, so am not 100% confident to provide review. From my perspective it looks good (thanks for the updates) but I'd coordinate with @hurtstotouchfire to land it.
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to keep passing required checks.
We added a new required check, "Tests Successful," that this PR does not yet run. Rebasing will get it started.
If you have any questions, please reach out to the Architecture team (either #architecture on Open edX Slack or #external-architecture on edX internal Slack).
@hurtstotouchfire @jristau1984 There were a couple salient notes above:
- This is transitioning
- That a synchronous convo might be required to land this.
This looks valuable and straight-forward, but y'all are the most intensive users of this feature I believe. What are the best next steps?
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.
EdX Release Notice: This PR has been deployed to the production environment.