edx-lint icon indicating copy to clipboard operation
edx-lint copied to clipboard

fix: pin event-tracking for pymongo 4.4.0 support

Open Ian2012 opened this issue 1 year ago • 1 comments

Description:

Pins event-tracking to a version before installing pymongo 4.4.0 which is not supported on edx-platform.

See https://github.com/openedx/tutor-contrib-aspects/issues/891, https://github.com/openedx/event-routing-backends/pull/436, https://github.com/openedx/completion/pull/305 for more information.

Merge checklist:

  • [ ] All reviewers approved
  • [ ] CI build is green
  • [ ] If adding new checks, followed how_tos/0001-adding-new-checks.rst
  • [ ] Changelog record added (if needed)
  • [ ] Documentation updated (not only docstrings) (if needed)
  • [ ] Commits are squashed

Ian2012 avatar Jul 11 '24 13:07 Ian2012

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Jul 11 '24 13:07 openedx-webhooks

I think this is the right solution until https://github.com/openedx/edx-platform/pull/34675 lands, does that make sense to you @mumarkhan999 ? @feanil is looking at the issues with commitlint on this repo currently.

bmtcril avatar Jul 15 '24 18:07 bmtcril

Commitlint issue should be fixed if you rebase off the latest master branch.

feanil avatar Jul 15 '24 18:07 feanil

@feanil thanks, it's ready for review now

Ian2012 avatar Jul 16 '24 17:07 Ian2012

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jul 16 '24 20:07 openedx-webhooks