ecommerce icon indicating copy to clipboard operation
ecommerce copied to clipboard

build: add python 3.11 and 3.12 ci checks

Open Danyal-Faheem opened this issue 1 year ago • 4 comments

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • [x] I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

  • [ ] Before deploying this change, complete a purchase in the stage environment. (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

  • Added CI checks as part of the upgrade process to python 3.11 and python 3.12.
  • Also fixes one part of the downstream issue in tutor-ecommerce.
  • Updated docker-compose to docker compose.
  • Changed the docker-compose file to build the image from the Dockerfile provided inside the repository rather than the provided image on dockerhub.
  • Updated the Dockerfile to have the PYTHON_VERSION as an Argument with 3.12 as the default version.
  • Added the PYTHON_ENV variable to utilize the matrix values to test against multiple python versions.
  • Updated the tox.ini fle to include py311 and py312 as well.
  • Build docs against python 3.11 and 3.12 as well.

Danyal-Faheem avatar Apr 18 '24 09:04 Danyal-Faheem

@feanil Hi. Can you run the workflows on this PR, please? Thanks

DawoudSheraz avatar Apr 29 '24 11:04 DawoudSheraz

Hi @andrey-canon. Thank you for pointing out the problem. The Dockerfile is currently forcing python3.8 in the containers. I'll update the PR to allow different python versions to be installed.

Danyal-Faheem avatar May 03 '24 06:05 Danyal-Faheem

@Danyal-Faheem do we have an update on this PR? It looks like once we get it working, we'll need to backport this to Redwood as well.

feanil avatar May 09 '24 16:05 feanil

Hi @feanil, we're still working on this PR. It needs some changes in the Dockerfile as well. We will try to get it done as soon as possible so that we can backport it to redwood.

Danyal-Faheem avatar May 10 '24 06:05 Danyal-Faheem

@Danyal-Faheem and I have tested the changes, there's still some python tests failing under test-python workflow. We have added pylintrc file to ignore some of the pylint warnings. We also had to upgrade some requirements so that CI checks also work with python 3.(8,11,12). Thats the update for now!

Faraz32123 avatar May 28 '24 10:05 Faraz32123

Hi @feanil, this PR is ready for review. Can you take a look? Thanks.

Faraz32123 avatar May 31 '24 09:05 Faraz32123

Hi @feanil, this PR is ready for review. Can you take a look? Thanks.

Hello @feanil, Hope so you are doing well. A soft reminder for you. So that this issue can be closed. Thanks.

Faraz32123 avatar Jun 05 '24 09:06 Faraz32123

Hello @andrey-canon, Can u also have a look at this PR for me. Thanks.

Faraz32123 avatar Jun 05 '24 09:06 Faraz32123

Hello @andrey-canon, Can u also have a look at this PR for me. Thanks.

Hi @Faraz32123, sure, no problem, however I cannot do that this week, so I will review this next one : D

andrey-canon avatar Jun 05 '24 15:06 andrey-canon

Hello @feanil and @andrey-canon, I hope you guys are doing well, a reminder for you guys to review this PR for this issue to be closed. Thanks.

Faraz32123 avatar Jun 11 '24 07:06 Faraz32123

Hello @andrey-canon, thanks for the review. I have updated the code according to the requested changes. Can u look into it again so that we can finalize it.

Faraz32123 avatar Jun 13 '24 10:06 Faraz32123

Hello @feanil, Can you also have a look at the backport PR to redwood and merge it. Thanks.

Faraz32123 avatar Jun 20 '24 19:06 Faraz32123