ecommerce icon indicating copy to clipboard operation
ecommerce copied to clipboard

[BB-4552] feat: Add support for fixed rate in ecommerce

Open alfredchavez opened this issue 4 years ago • 10 comments

BB-4552: Add support for a fixed rate for all products in ecommerce

Description

Ecommerce does not support tax rates for its payments(DefaultStrategy uses a NoTax strategy), this PR adds support for a fixed tax rate through a new django setting TAX_RATE that is applied to all products. Also the default value for the TAX_RATE setting is 0.0, preserving the previous platform behaviour.

Supporting information

Jira Issue: BB-4552

Testing instructions

  • Check that the added tests make sense and run without failure

  • Change the TAX_RATE to a decimal value(like "0.3")

  • Try to make a purchase(could be the certificate upgrade of the demo course)

  • Verify that the total value displayed on basket and invoice includes the tax rate

alfredchavez avatar Aug 11 '21 16:08 alfredchavez

Thanks for the pull request, @alfredchavez! I've created OSPR-5961 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Aug 11 '21 16:08 openedx-webhooks

@natabene @nedbat It looks like the CI checks weren't triggered for this (@alfredchavez is a member of OpenCraft, and this was created from our fork). Can you check or trigger a CI run for this?

giovannicimolin avatar Aug 17 '21 21:08 giovannicimolin

~~jenkins run all~~

Didn't work, but it was worth a shot...

giovannicimolin avatar Aug 17 '21 21:08 giovannicimolin

@alfredchavez Thank you for your contribution. @giovannicimolin I will kick them off now.

natabene avatar Aug 18 '21 14:08 natabene

@alfredchavez Quality checks are failing, can you fix them (plus any other CI issues) and ping me for another review round Monday?

giovannicimolin avatar Aug 19 '21 19:08 giovannicimolin

Hi @giovannicimolin I have fixed the "import order" issues, but CI checks are not running until approval

alfredchavez avatar Aug 23 '21 10:08 alfredchavez

@natabene Can you kick off the CI checks here again? Is there something we can do to unblock these checks from OpenCraft repos?

giovannicimolin avatar Aug 23 '21 13:08 giovannicimolin

@alfredchavez Can you double-check that all tests are passing locally?

giovannicimolin avatar Aug 23 '21 13:08 giovannicimolin

@natabene Can you trigger a CI run for this again?

giovannicimolin avatar Aug 27 '21 17:08 giovannicimolin

Ok, I think they are running now.

natabene avatar Sep 02 '21 02:09 natabene

@giovannicimolin is this still in progress? Or, can it be closed?

mphilbrick211 avatar Nov 07 '22 18:11 mphilbrick211

@giovannicimolin is this still in progress? Or, can it be closed?

Friendly ping on this @giovannicimolin :)

mphilbrick211 avatar Nov 30 '22 17:11 mphilbrick211

@mphilbrick211 Sorry for missing the pings.

We will not be pursuing this any longer, but I don't have permission to close the PR. Can you close it for me?

giovannicimolin avatar Dec 01 '22 14:12 giovannicimolin

Closing, per Giovanni.

mphilbrick211 avatar Dec 07 '22 22:12 mphilbrick211

@alfredchavez Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Dec 07 '22 22:12 openedx-webhooks