bump: add ddtrace in Gemfile
Ths change add ddtrace, which is used in https://github.com/openedx/cs_comments_service/blob/8626d44a6322a813e8c58140b8b2f3039735709c/config/unicorn_tcp.rb#L15
Related issue:
- https://github.com/overhangio/tutor-forum/issues/33
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@ghassanmas The ruby CI is failing on this. Can you please check why?
@feanil Hi, it seems the CI is failing due to the missing codecov token.
Yes it same issue with other reop once fixed I can rebase
I've added the token, you should be able to update the workflow and get coverage working again.
I am not sure if what I did is the correct way to update the workflow.... orginally this repo relied on codecov 0.6..0 gem, which is already deprecated, the readme recommend to use github action CI direclty...
Hi @ghassanmas, thank you for this contribution!
@asadazam93 @DawoudSheraz Would you have any tips for Ghassan about how to fix the failing build here?
Hi @ghassanmas, thank you for this contribution!
@asadazam93 @DawoudSheraz Would you have any tips for Ghassan about how to fix the failing build here?
Hi. Unfortunately, I don't have context on this. Tagging @feanil as he might have some context for this. Thanks
@ghassanmas I'm taking a look at this. I think actually ddtrace should not have been added as an explicit requirement so I'm digging a bit further.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.19%. Comparing base (
8626d44) to head (5b9b421).
Additional details and impacted files
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 58 58
Lines 4624 4624
=======================================
Hits 4448 4448
Misses 176 176
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@feanil now that the builds is success, shall this await for ddtrace ? or is ready to be reviewed
I think it's fine to have dd-trace in here for now and we'll follow up on it separately. We can probably just leave it since it's not hurting anything and we're potentially investing in a replacement app soon.
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.