cs_comments_service icon indicating copy to clipboard operation
cs_comments_service copied to clipboard

bump: add ddtrace in Gemfile

Open ghassanmas opened this issue 1 year ago • 6 comments

Ths change add ddtrace, which is used in https://github.com/openedx/cs_comments_service/blob/8626d44a6322a813e8c58140b8b2f3039735709c/config/unicorn_tcp.rb#L15

Related issue:

  • https://github.com/overhangio/tutor-forum/issues/33

ghassanmas avatar May 02 '24 14:05 ghassanmas

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar May 02 '24 14:05 openedx-webhooks

@ghassanmas The ruby CI is failing on this. Can you please check why?

asadazam93 avatar May 06 '24 07:05 asadazam93

@feanil Hi, it seems the CI is failing due to the missing codecov token.

DawoudSheraz avatar May 06 '24 11:05 DawoudSheraz

Yes it same issue with other reop once fixed I can rebase

ghassanmas avatar May 06 '24 12:05 ghassanmas

I've added the token, you should be able to update the workflow and get coverage working again.

feanil avatar May 06 '24 14:05 feanil

I am not sure if what I did is the correct way to update the workflow.... orginally this repo relied on codecov 0.6..0 gem, which is already deprecated, the readme recommend to use github action CI direclty...

ghassanmas avatar May 07 '24 15:05 ghassanmas

Hi @ghassanmas, thank you for this contribution!

@asadazam93 @DawoudSheraz Would you have any tips for Ghassan about how to fix the failing build here?

itsjeyd avatar May 23 '24 15:05 itsjeyd

Hi @ghassanmas, thank you for this contribution!

@asadazam93 @DawoudSheraz Would you have any tips for Ghassan about how to fix the failing build here?

Hi. Unfortunately, I don't have context on this. Tagging @feanil as he might have some context for this. Thanks

DawoudSheraz avatar May 24 '24 05:05 DawoudSheraz

@ghassanmas I'm taking a look at this. I think actually ddtrace should not have been added as an explicit requirement so I'm digging a bit further.

feanil avatar Jun 04 '24 14:06 feanil

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (8626d44) to head (5b9b421).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          58       58           
  Lines        4624     4624           
=======================================
  Hits         4448     4448           
  Misses        176      176           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 14 '24 14:06 codecov[bot]

@feanil now that the builds is success, shall this await for ddtrace ? or is ready to be reviewed

ghassanmas avatar Jun 14 '24 14:06 ghassanmas

I think it's fine to have dd-trace in here for now and we'll follow up on it separately. We can probably just leave it since it's not hurting anything and we're potentially investing in a replacement app soon.

feanil avatar Jun 20 '24 18:06 feanil

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jun 20 '24 18:06 openedx-webhooks