credentials icon indicating copy to clipboard operation
credentials copied to clipboard

feat: add badges feature

Open kyrylo-kh opened this issue 1 year ago • 4 comments

Description: This pull request implements Credly integration feature.

Changes:

  • Creates new badges application.
  • Extends documentation with badges section.
  • Extends set of credentials

Related documentation: See temporarily deployed documentation https://raccoongang.github.io/credentials/badges/index.html

Related PR's:

  • https://github.com/openedx/openedx-events/pull/303
  • https://github.com/openedx/edx-platform/pull/34749

kyrylo-kh avatar May 24 '24 18:05 kyrylo-kh

Thanks for the pull request, @kyrylo-kh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks avatar May 24 '24 18:05 openedx-webhooks

@wowkalucky @GlugovGrGlib please review this PR

kyrylo-kh avatar Jun 04 '24 10:06 kyrylo-kh

Just dropping a line to say I'm starting my review this morning.

justinhynes avatar Jun 18 '24 14:06 justinhynes

@justinhynes Hi, just wanted to thank you for your remarks. We have gone through all of them and given appropriate responses where no fixes needed. All relevant problems have been fixed. Kindly look at the code again when time allows you to do so :)

andrii-hantkovskyi avatar Jul 10 '24 11:07 andrii-hantkovskyi

Hi @andrii-hantkovskyi. Apologies, I missed your last update until today.

I will block out some time to re-review. Thanks for the heads up :)

justinhynes avatar Jul 17 '24 12:07 justinhynes

@kyrylo-kh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jul 22 '24 14:07 openedx-webhooks