ods-quickstarters icon indicating copy to clipboard operation
ods-quickstarters copied to clipboard

Add build agent for Node.js 18 (master)

Open cschweikert opened this issue 3 years ago • 8 comments

  • add jenkins-agent for Node.js 18
  • update chrome to 100.0.4896.127 (latest)
  • update documentation

Fixes #794

Tasks:

  • [x] Updated documentation in docs/modules/... directory

cschweikert avatar Apr 25 '22 13:04 cschweikert

Hm, builds are failing. Doesn't find all of the dependencies yet. Maybe because Node.js 18 was released only a week ago. I'll try again later and keep you posted.

cschweikert avatar Apr 25 '22 13:04 cschweikert

Hi @cschweikert @tbugfinder -> nodesource It seems nodejs18 is not working with Centos 7 and Rhel7

BraisVQ avatar Jun 10 '22 09:06 BraisVQ

@braisvq1996 good point. Does anything speak against moving on to Centos/RHEL 8? Like already mentioned in one of the discussions above I have no clue about the implications of this switch (e.g. just for the nodejs18 thingy). If it is fine, I can also try that out for now.

cschweikert avatar Jun 10 '22 10:06 cschweikert

Switching to Centos8 and/or Rhel8 is a big change. Right now if we do it the ODSBox we have will not work but this is something we would need to do sooner or later image

BraisVQ avatar Jun 10 '22 10:06 BraisVQ

@braisvq1996 I think this just confirms that you'll need to investigate an alternative to the current ODS Box. Maintaining CentOS/RHEL7 base images will be a hassle more and more, plus the box is OpenShift 3.11 only so won't give you reliable results. The box should not block the uptake of Node 18 I believe.

michaelsauter avatar Jun 10 '22 11:06 michaelsauter

@michaelsauter you have your reason, the box is using OKD3, and this does not "help" for Openshift 4 tests.... Either way I would not break the box "on purpose" if we can avoid it

BraisVQ avatar Jun 13 '22 07:06 BraisVQ

As per my understanding nodejs project will not build CentOS7 binaries. https://github.com/nodejs/node/issues/43246

So for CentOS7 we could compile proper GLIBC version 2.27 within the Image and see if that would work with the RHEL8 binary.

In regards to the ubi8 image, do you want to wait for RHEL providing nodejs18 repo (sounds like Sept/Oct timeframe) or use the installer of the CentOS7 Dockerfile which would already be available.

tbugfinder avatar Jul 12 '22 10:07 tbugfinder

@braisvq1996 @cschweikert NodeJS 18 + ubi8 built successfully.

IMHO, CentOS7 support has to dropped here to move forward.

tbugfinder avatar Dec 08 '22 20:12 tbugfinder

@tbugfinder @cschweikert centos agents have been removed so if the conficts get resolved we could merge this into master

BraisVQ avatar Feb 13 '23 09:02 BraisVQ

I have already removed centos from this pr so if there is anything left to update as it has been quite some time since its creation we can do it and merge it

BraisVQ avatar Feb 13 '23 15:02 BraisVQ

@braisvq1996 thanks finishing this one ❤️

cschweikert avatar Feb 13 '23 20:02 cschweikert