public icon indicating copy to clipboard operation
public copied to clipboard

Add update-generation container in bgp global

Open shimangkumar opened this issue 3 years ago • 6 comments

Added a new container update-generation to configure update generation message parameters under bgp global. update-generation conatiner have one leaf wait-fib-install of boolean type and default value as false. wait-fib-install is used to postpone the route advertisment untill installed in FIB.

shimangkumar avatar Aug 30 '22 11:08 shimangkumar

Compatibility Report for commit 6e95b41239a04a3e27033ecf62d0cbffcb502f45: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Aug 30 '22 11:08 OpenConfigBot

@dplore @robshakir

akalluru1 avatar Aug 30 '22 17:08 akalluru1

I will bring to the openconfig operators meeting for Sep 20, 2022

dplore avatar Sep 15 '22 22:09 dplore

Can we first follow contributor guidelines and reference other implementation support along with proper explanation and justification?

earies avatar Sep 16 '22 16:09 earies

Added a new container update-generation under BGP global tree.

bgp
 |
 | --- global
       |
       | --- update-generation
             |
             | --- config
                   |
                   | --- wait-fib-install
  

update-generation container will have leaf related to update message generation.

In this container currently added one leaf wait-fib-install of type boolean with default value as false

wait-fib-install is related to postpone update generation until route is not installed in fib.

Here is the command snippet related to configuration of wait-fib-install:

(config)#router bgp 1
(config-router-bgp)#?
  ...
  update                    Configure BGP update generation
  ...
(config-router-bgp)#update ?
  ...
  wait-install          Synchronize update generation with route programming in the FIB
(config-router-bgp)#update wait-install ?
  batch-size  batch size for FIB route acknowledgements
  <cr>
(config-router-bgp)#update wait-install batch-size ?
  <0-10000>  batch size
(config-router-bgp)#update wait-install batch-size 1000
(config-router-bgp)#exit
(config)#sh run sec router bgp
router bgp 1
   update wait-install batch-size 1000
(config)#

We need to add a leaf only for update wait-install keyword.

shimangkumar avatar Sep 21 '22 15:09 shimangkumar

Thanks @shimangkumar , can you please reference at least two implementations from different companies? It is most helpful if you can add URL references to documentation describing the feature.

dplore avatar Sep 22 '22 01:09 dplore