public icon indicating copy to clipboard operation
public copied to clipboard

Add ip-address-zoned union type for link-local neighbor addresses

Open mcarri01 opened this issue 4 years ago • 8 comments

Similar to the existing typedef for ip-address, this new typedef provides a union between existing ipv4-address-zoned and ipv6-address-zoned types that are used by link-local peering.

Currently systems such as Arista's EOS support link-local peering. In particular when dealing with BGP IPv6 link-local peering, the current neighbor-address key is incompatible as it requires an ip-address type. With this new union typedef, it may be possible to update the neighbor-address key for BGP peer information to use this new "ip-address-zoned" key instead to allow supporting link-local peers. This change should be backwards compatible as it simply relaxes the restrictions on the key type.

mcarri01 avatar Aug 17 '21 19:08 mcarri01

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 17 '21 19:08 googlebot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Aug 17 '21 19:08 google-cla[bot]

Compatibility Report for commit 613c833a426e32232e424b098ff6362183555f9e: ⛔ yanglint@SO 1.10.17

OpenConfigBot avatar Aug 17 '21 19:08 OpenConfigBot

@googlebot I signed it!

mcarri01 avatar Aug 18 '21 01:08 mcarri01

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 18 '21 01:08 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Aug 18 '21 01:08 google-cla[bot]

Thanks for the contribution, this LGTM. I'll shepherd this upstream.

robshakir avatar Oct 19 '21 07:10 robshakir

Thanks Rob, appreciate. it. Just wanted to check in to see what the timeline would be for this to get shepherded upstream? Had honestly forgot about this PR and realized it was still open.

mcarri01 avatar Dec 09 '21 20:12 mcarri01

I think this request may be obsoleted by #793 . If you disagree, please feel free to request reopening this PR.

dplore avatar Feb 07 '23 06:02 dplore