kne icon indicating copy to clipboard operation
kne copied to clipboard

Add the ability to provide pre-generated certs

Open alexmasi opened this issue 1 year ago • 2 comments

Currently self-signed is the only cert type provided, this PR adds another option to the topo proto but does not yet add support to node impls to use the new field.

A follow up PR will use the field.

alexmasi avatar Jul 02 '24 21:07 alexmasi

Pull Request Test Coverage Report for Build 9768506569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 65.198%

Files with Coverage Reduction New Missed Lines %
topo/node/arista/arista.go 1 71.34%
<!-- Total: 1
Totals Coverage Status
Change from base Build 9765987846: -0.01%
Covered Lines: 4646
Relevant Lines: 7126

💛 - Coveralls

coveralls avatar Jul 02 '24 22:07 coveralls

This has been top of mind for me, so thanks for tackling it. Generating certs is the slowest part of topology creation in many cases!

chrisy avatar Jul 02 '24 23:07 chrisy