kne icon indicating copy to clipboard operation
kne copied to clipboard

Add ondatra test to presubmit

Open alexmasi opened this issue 3 years ago • 4 comments

alexmasi avatar Oct 18 '22 22:10 alexmasi

/gcbrun

alexmasi avatar Oct 18 '22 22:10 alexmasi

Pull Request Test Coverage Report for Build 3333365663

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 57.509%

Files with Coverage Reduction New Missed Lines %
topo/node/node.go 8 19.74%
<!-- Total: 8
Totals Coverage Status
Change from base Build 3323339077: 0.0%
Covered Lines: 2313
Relevant Lines: 4022

💛 - Coveralls

coveralls avatar Oct 18 '22 22:10 coveralls

/gcbrun

alexmasi avatar Oct 18 '22 23:10 alexmasi

this will likely timeout due to loading of very large e8000 image

alexmasi avatar Oct 18 '22 23:10 alexmasi

/gcbrun

alexmasi avatar Oct 19 '22 20:10 alexmasi

/gcbrun

alexmasi avatar Oct 19 '22 21:10 alexmasi

/gcbrun

alexmasi avatar Oct 20 '22 17:10 alexmasi

/gcbrun

alexmasi avatar Oct 20 '22 19:10 alexmasi

/gcbrun

alexmasi avatar Oct 21 '22 19:10 alexmasi

/gcbrun

alexmasi avatar Oct 24 '22 20:10 alexmasi

/gcbrun

alexmasi avatar Oct 24 '22 21:10 alexmasi

/gcbrun

alexmasi avatar Oct 24 '22 22:10 alexmasi

/gcbrun

alexmasi avatar Oct 24 '22 22:10 alexmasi

Presubmit has issue bringing up ceos node (same as b/254952420)

alexmasi avatar Oct 24 '22 23:10 alexmasi

/gcbrun

alexmasi avatar Oct 25 '22 18:10 alexmasi

/gcbrun

alexmasi avatar Oct 25 '22 20:10 alexmasi

/gcbrun

alexmasi avatar Oct 25 '22 20:10 alexmasi

/gcbrun

alexmasi avatar Oct 25 '22 21:10 alexmasi

/gcbrun

alexmasi avatar Oct 25 '22 22:10 alexmasi

The included ondatra test will not be used in the presubmit until the config reset through ondatra knebind works as expected for all vendors (currently there are timeout issues)

alexmasi avatar Oct 26 '22 23:10 alexmasi

/gcbrun

alexmasi avatar Oct 27 '22 00:10 alexmasi